yoctore/yocto-status-codes

View on GitHub

Showing 12 of 12 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            joi.object().keys({
              code      : joi.number().integer().required(),
              codeHTTP  : joi.number().integer().required(),
              status    : joi.string().required().empty(),
              label     : joi.string().required().empty(),
Severity: Major
Found in src/index.js and 1 other location - About 5 hrs to fix
src/index.js on lines 146..152

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 147.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                joi.object().keys({
                  code      : joi.number().integer().required(),
                  codeHTTP  : joi.number().integer().required(),
                  status    : joi.string().required().empty(),
                  label     : joi.string().required().empty(),
Severity: Major
Found in src/index.js and 1 other location - About 5 hrs to fix
src/index.js on lines 136..142

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 147.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function get has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

StatusCodes.prototype.get = function (category, code, data) {

  // Initialise subCode if is not define
  code = code || '000';

Severity: Major
Found in src/index.js - About 2 hrs to fix

    Function has a complexity of 11.
    Open

    StatusCodes.prototype.get = function (category, code, data) {
    Severity: Minor
    Found in src/index.js by eslint

    Limit Cyclomatic Complexity (complexity)

    Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

    function a(x) {
        if (true) {
            return x; // 1st path
        } else if (false) {
            return x+1; // 2nd path
        } else {
            return 4; // 3rd path
        }
    }

    Rule Details

    This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

    Examples of incorrect code for a maximum of 2:

    /*eslint complexity: ["error", 2]*/
    
    function a(x) {
        if (true) {
            return x;
        } else if (false) {
            return x+1;
        } else {
            return 4; // 3rd path
        }
    }

    Examples of correct code for a maximum of 2:

    /*eslint complexity: ["error", 2]*/
    
    function a(x) {
        if (true) {
            return x;
        } else {
            return 4;
        }
    }

    Options

    Optionally, you may specify a max object property:

    "complexity": ["error", 2]

    is equivalent to

    "complexity": ["error", { "max": 2 }]

    Deprecated: the object property maximum is deprecated. Please use the property max instead.

    When Not To Use It

    If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

    Further Reading

    Related Rules

    • [max-depth](max-depth.md)
    • [max-len](max-len.md)
    • [max-nested-callbacks](max-nested-callbacks.md)
    • [max-params](max-params.md)
    • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

    Function loadConfig has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    StatusCodes.prototype.loadConfig = function (pathFile) {
      // try to load external file
      try {
    
        // Parse the file
    Severity: Minor
    Found in src/index.js - About 1 hr to fix

      Function exports has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = function (grunt) {
        // init config
        grunt.initConfig({
          // default package
          pkg       : grunt.file.readJSON('package.json'),
      Severity: Minor
      Found in Gruntfile.js - About 1 hr to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        StatusCodes.prototype.systemError = function (data, message) {
          // default statement
          return this.buildDefault('system', data || {}, message || '');
        };
        Severity: Major
        Found in src/index.js and 2 other locations - About 45 mins to fix
        src/index.js on lines 88..91
        src/index.js on lines 100..103

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        StatusCodes.prototype.success = function (data, message) {
          // default statement
          return this.buildDefault('success', data || {}, message || '');
        };
        Severity: Major
        Found in src/index.js and 2 other locations - About 45 mins to fix
        src/index.js on lines 100..103
        src/index.js on lines 112..115

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        StatusCodes.prototype.error = function (data, message) {
          // default statement
          return this.buildDefault('error', data || {}, message || '');
        };
        Severity: Major
        Found in src/index.js and 2 other locations - About 45 mins to fix
        src/index.js on lines 88..91
        src/index.js on lines 112..115

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function buildDefault has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        StatusCodes.prototype.buildDefault = function (type, data, message) {
          // type exists ?
          if (_.has(this.defaultStatus, type) && _.isString(type)) {
            // default statement
            var d  = _.extend({}, _.clone(this.defaultStatus[type]), { message : '', data : {} });
        Severity: Minor
        Found in src/index.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function get has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        StatusCodes.prototype.get = function (category, code, data) {
        
          // Initialise subCode if is not define
          code = code || '000';
        
        
        Severity: Minor
        Found in src/index.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Unexpected trailing comma.
        Open

                  reporter : 'spec',
        Severity: Minor
        Found in Gruntfile.js by eslint

        require or disallow trailing commas (comma-dangle)

        Trailing commas in object literals are valid according to the ECMAScript 5 (and ECMAScript 3!) spec. However, IE8 (when not in IE8 document mode) and below will throw an error when it encounters trailing commas in JavaScript.

        var foo = {
            bar: "baz",
            qux: "quux",
        };

        Trailing commas simplify adding and removing items to objects and arrays, since only the lines you are modifying must be touched. Another argument in favor of trailing commas is that it improves the clarity of diffs when an item is added or removed from an object or array:

        Less clear:

        var foo = {
        -    bar: "baz",
        -    qux: "quux"
        +    bar: "baz"
         };

        More clear:

        var foo = {
             bar: "baz",
        -    qux: "quux",
         };

        Rule Details

        This rule enforces consistent use of trailing commas in object and array literals.

        Options

        This rule has a string option or an object option:

        {
            "comma-dangle": ["error", "never"],
            // or
            "comma-dangle": ["error", {
                "arrays": "never",
                "objects": "never",
                "imports": "never",
                "exports": "never",
                "functions": "ignore",
            }]
        }
        • "never" (default) disallows trailing commas
        • "always" requires trailing commas
        • "always-multiline" requires trailing commas when the last element or property is in a different line than the closing ] or } and disallows trailing commas when the last element or property is on the same line as the closing ] or }
        • "only-multiline" allows (but does not require) trailing commas when the last element or property is in a different line than the closing ] or } and disallows trailing commas when the last element or property is on the same line as the closing ] or }

        Trailing commas in function declarations and function calls are valid syntax since ECMAScript 2017; however, the string option does not check these situations for backwards compatibility.

        You can also use an object option to configure this rule for each type of syntax. Each of the following options can be set to "never", "always", "always-multiline", "only-multiline", or "ignore". The default for each option is "never" unless otherwise specified.

        • arrays is for array literals and array patterns of destructuring. (e.g. let [a,] = [1,];)
        • objects is for object literals and object patterns of destructuring. (e.g. let {a,} = {a: 1};)
        • imports is for import declarations of ES Modules. (e.g. import {a,} from "foo";)
        • exports is for export declarations of ES Modules. (e.g. export {a,};)
        • functions is for function declarations and function calls. (e.g. (function(a,){ })(b,);)
          functions is set to "ignore" by default for consistency with the string option.

        never

        Examples of incorrect code for this rule with the default "never" option:

        /*eslint comma-dangle: ["error", "never"]*/
        
        var foo = {
            bar: "baz",
            qux: "quux",
        };
        
        var arr = [1,2,];
        
        foo({
          bar: "baz",
          qux: "quux",
        });

        Examples of correct code for this rule with the default "never" option:

        /*eslint comma-dangle: ["error", "never"]*/
        
        var foo = {
            bar: "baz",
            qux: "quux"
        };
        
        var arr = [1,2];
        
        foo({
          bar: "baz",
          qux: "quux"
        });

        always

        Examples of incorrect code for this rule with the "always" option:

        /*eslint comma-dangle: ["error", "always"]*/
        
        var foo = {
            bar: "baz",
            qux: "quux"
        };
        
        var arr = [1,2];
        
        foo({
          bar: "baz",
          qux: "quux"
        });

        Examples of correct code for this rule with the "always" option:

        /*eslint comma-dangle: ["error", "always"]*/
        
        var foo = {
            bar: "baz",
            qux: "quux",
        };
        
        var arr = [1,2,];
        
        foo({
          bar: "baz",
          qux: "quux",
        });

        always-multiline

        Examples of incorrect code for this rule with the "always-multiline" option:

        /*eslint comma-dangle: ["error", "always-multiline"]*/
        
        var foo = {
            bar: "baz",
            qux: "quux"
        };
        
        var foo = { bar: "baz", qux: "quux", };
        
        var arr = [1,2,];
        
        var arr = [1,
            2,];
        
        var arr = [
            1,
            2
        ];
        
        foo({
          bar: "baz",
          qux: "quux"
        });

        Examples of correct code for this rule with the "always-multiline" option:

        /*eslint comma-dangle: ["error", "always-multiline"]*/
        
        var foo = {
            bar: "baz",
            qux: "quux",
        };
        
        var foo = {bar: "baz", qux: "quux"};
        var arr = [1,2];
        
        var arr = [1,
            2];
        
        var arr = [
            1,
            2,
        ];
        
        foo({
          bar: "baz",
          qux: "quux",
        });

        only-multiline

        Examples of incorrect code for this rule with the "only-multiline" option:

        /*eslint comma-dangle: ["error", "only-multiline"]*/
        
        var foo = { bar: "baz", qux: "quux", };
        
        var arr = [1,2,];
        
        var arr = [1,
            2,];

        Examples of correct code for this rule with the "only-multiline" option:

        /*eslint comma-dangle: ["error", "only-multiline"]*/
        
        var foo = {
            bar: "baz",
            qux: "quux",
        };
        
        var foo = {
            bar: "baz",
            qux: "quux"
        };
        
        var foo = {bar: "baz", qux: "quux"};
        var arr = [1,2];
        
        var arr = [1,
            2];
        
        var arr = [
            1,
            2,
        ];
        
        var arr = [
            1,
            2
        ];
        
        foo({
          bar: "baz",
          qux: "quux",
        });
        
        foo({
          bar: "baz",
          qux: "quux"
        });

        functions

        Examples of incorrect code for this rule with the {"functions": "never"} option:

        /*eslint comma-dangle: ["error", {"functions": "never"}]*/
        
        function foo(a, b,) {
        }
        
        foo(a, b,);
        new foo(a, b,);

        Examples of correct code for this rule with the {"functions": "never"} option:

        /*eslint comma-dangle: ["error", {"functions": "never"}]*/
        
        function foo(a, b) {
        }
        
        foo(a, b);
        new foo(a, b);

        Examples of incorrect code for this rule with the {"functions": "always"} option:

        /*eslint comma-dangle: ["error", {"functions": "always"}]*/
        
        function foo(a, b) {
        }
        
        foo(a, b);
        new foo(a, b);

        Examples of correct code for this rule with the {"functions": "always"} option:

        /*eslint comma-dangle: ["error", {"functions": "always"}]*/
        
        function foo(a, b,) {
        }
        
        foo(a, b,);
        new foo(a, b,);

        When Not To Use It

        You can turn this rule off if you are not concerned with dangling commas. Source: http://eslint.org/docs/rules/

        Severity
        Category
        Status
        Source
        Language