Sign upLogin

yoghi/madda

View on GitHub
Star
Generator/DDDGenerator.php

Summary

Maintainability
F
4 days
Test Coverage

Function generate has a Cognitive Complexity of 146 (exceeds 5 allowed). Consider refactoring.
Open

    public function generate(Local $directoryOutput)
    {
        //$is_constructor_enable = true;
        //$ddd_is_root_aggregate = false;
Severity: Minor
Found in Generator/DDDGenerator.php - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method generate has 219 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function generate(Local $directoryOutput)
    {
        //$is_constructor_enable = true;
        //$ddd_is_root_aggregate = false;
Severity: Major
Found in Generator/DDDGenerator.php - About 1 day to fix

    File DDDGenerator.php has 266 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace Yoghi\Bundle\MaddaBundle\Generator;

/*
    Severity: Minor
    Found in Generator/DDDGenerator.php - About 2 hrs to fix

      The method generate() has 288 lines of code. Current threshold is set to 100. Avoid really long methods.
      Open

          public function generate(Local $directoryOutput)
    {
        //$is_constructor_enable = true;
        //$ddd_is_root_aggregate = false;
      Severity: Minor
      Found in Generator/DDDGenerator.php by phpmd

      The method generate() has an NPath complexity of 716885569. The configured NPath complexity threshold is 200.
      Open

          public function generate(Local $directoryOutput)
    {
        //$is_constructor_enable = true;
        //$ddd_is_root_aggregate = false;
      Severity: Minor
      Found in Generator/DDDGenerator.php by phpmd

      NPathComplexity

      Since: 0.1

      The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

      Example

      class Foo {
    function bar() {
        // lots of complicated code
    }
}

      Source https://phpmd.org/rules/codesize.html#npathcomplexity

      The method generate() has a Cyclomatic Complexity of 40. The configured cyclomatic complexity threshold is 10.
      Open

          public function generate(Local $directoryOutput)
    {
        //$is_constructor_enable = true;
        //$ddd_is_root_aggregate = false;
      Severity: Minor
      Found in Generator/DDDGenerator.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      Possibly zero references to public method \Yoghi\Bundle\MaddaBundle\Generator\DDDGenerator::analyze()
      Open

          public function analyze($fullPathFile)
      Severity: Minor
      Found in Generator/DDDGenerator.php by phan

      FIXME found
      Open

                      $generated = true; //FIXME: use $g for determinate! -> take error from generator
      Severity: Minor
      Found in Generator/DDDGenerator.php by fixme

      Possibly zero references to public method \Yoghi\Bundle\MaddaBundle\Generator\DDDGenerator::getErrors()
      Open

          public function getErrors()
      Severity: Minor
      Found in Generator/DDDGenerator.php by phan

      Saw unextractable annotation for comment '* @param [type] $fullPathFile [description]'
      Open

           * @param [type] $fullPathFile [description]
      Severity: Info
      Found in Generator/DDDGenerator.php by phan

      Saw unextractable annotation for comment '* @return [type] [description]'
      Open

           * @return [type] [description]
      Severity: Info
      Found in Generator/DDDGenerator.php by phan

      Suspicious array access to nullable ?array{ddd:array{type:'class'}}|?array{ddd:array{}}|?array{description:mixed,ddd:array{type:'class'}|array{},namespace:mixed}|?array{namespace:mixed,ddd:array{type:'class'}|array{}}|?mixed
      Open

                          $this->fieldsClass[$namespace.'\\'.$className] = $properties['fields']; //ONLY IF VALID!!!
      Severity: Minor
      Found in Generator/DDDGenerator.php by phan

      TODO found
      Open

                          //TODO: gestire gli [] dentro la definizione del modello se serve...
      Severity: Minor
      Found in Generator/DDDGenerator.php by fixme

      Suspicious array access to nullable ?array{ddd:array{type:'class'}}|?array{ddd:array{}}|?array{description:mixed,ddd:array{type:'class'}|array{},namespace:mixed}|?array{namespace:mixed,ddd:array{type:'class'}|array{}}|?mixed
      Open

                          $this->fieldsClass[$namespace.'\\'.$className] = $properties['fields']; //ONLY IF VALID!!!
      Severity: Minor
      Found in Generator/DDDGenerator.php by phan

      TODO found
      Open

                          //TODO: aggiungere le validazioni
      Severity: Minor
      Found in Generator/DDDGenerator.php by fixme

      Unused definition of variable $generated
      Open

                                  $generated = true;
      Severity: Minor
      Found in Generator/DDDGenerator.php by phan

      FIXME found
      Open

                      //FIXME: impossible! events exist in relation on aggregateRoot
      Severity: Minor
      Found in Generator/DDDGenerator.php by fixme

      FIXME found
      Open

                      $generated = true; //FIXME: use $g for determinate! -> take error from generator
      Severity: Minor
      Found in Generator/DDDGenerator.php by fixme

      Possibly zero references to public method \Yoghi\Bundle\MaddaBundle\Generator\DDDGenerator::generate()
      Open

          public function generate(Local $directoryOutput)
      Severity: Minor
      Found in Generator/DDDGenerator.php by phan

      TODO found
      Open

                                  //TODO: pensare se qui va bene cosi... potrebbe il ClassGenerator sapere come fare questo costruttore?
      Severity: Minor
      Found in Generator/DDDGenerator.php by fixme

      Invalid offset "root" of array type array{type:'class'}|array{}
      Open

                          $isRootAggregate = $dddType == 'aggregate' && isset($properties['ddd']['root']) && boolval($properties['ddd']['root']) ? true : false;
      Severity: Minor
      Found in Generator/DDDGenerator.php by phan

      FIXME found
      Open

                  //FIXME: switch with $dddType as key
      Severity: Minor
      Found in Generator/DDDGenerator.php by fixme

      Possibly zero references to public method \Yoghi\Bundle\MaddaBundle\Generator\DDDGenerator::setLogger()
      Open

          public function setLogger(LoggerInterface $logger)
      Severity: Minor
      Found in Generator/DDDGenerator.php by phan

      Avoid excessively long variable names like $namespaceImplementClass. Keep variable name length under 20.
      Open

                              $namespaceImplementClass = $this->modelClass[$eventsImplement];
      Severity: Minor
      Found in Generator/DDDGenerator.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid variables with short names like $g. Configured minimum length is 3.
      Open

                      $g = new ClassGenerator($namespace, $className, $classComments);
      Severity: Minor
      Found in Generator/DDDGenerator.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      There are no issues that match your filters.

      Category
      Status