Sign upLogin

yoghi/madda

View on GitHub
Star
Generator/RestGenerator.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method generateRest has 85 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function generateRest($ramlFile, Local $directoryOutput)
    {
        $parser = new Parser();
        try {
Severity: Major
Found in Generator/RestGenerator.php - About 3 hrs to fix

    Function generateRest has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        public function generateRest($ramlFile, Local $directoryOutput)
    {
        $parser = new Parser();
        try {
    Severity: Minor
    Found in Generator/RestGenerator.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The method generateRest() has 135 lines of code. Current threshold is set to 100. Avoid really long methods.
    Open

        public function generateRest($ramlFile, Local $directoryOutput)
    {
        $parser = new Parser();
        try {
    Severity: Minor
    Found in Generator/RestGenerator.php by phpmd

    The method generateRest() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
    Open

        public function generateRest($ramlFile, Local $directoryOutput)
    {
        $parser = new Parser();
        try {
    Severity: Minor
    Found in Generator/RestGenerator.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Avoid unused local variables such as '$infoSecuritySchema'.
    Open

                $infoSecuritySchema = $this->apiDef->getSecuredBy(); // descrive i vari security schema usati nelle varie risorse
    Severity: Minor
    Found in Generator/RestGenerator.php by phpmd

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    Avoid unused private methods such as 'removeGraph'.
    Open

        private function removeGraph(&$str)
    {
        $str = str_replace('{', '', $str);
        $str = str_replace('}', '', $str);
        $str = ucfirst($str);
    Severity: Minor
    Found in Generator/RestGenerator.php by phpmd

    UnusedPrivateMethod

    Since: 0.2

    Unused Private Method detects when a private method is declared but is unused.

    Example

    class Something
{
    private function foo() {} // unused
}

    Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

    Avoid unused local variables such as '$subResource'.
    Open

                    foreach ($subResources as $subResource) {
    Severity: Minor
    Found in Generator/RestGenerator.php by phpmd

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    Possibly zero references to use statement for classlike/namespace Method (\Nette\PhpGenerator\Method)
    Open

    use Nette\PhpGenerator\Method;
    Severity: Minor
    Found in Generator/RestGenerator.php by phan

    Suspicious type \League\Flysystem\Adapter\Local of a variable or expression used to build a string. (Expected type to be able to cast to a string)
    Open

                $this->info('Scrittura su '.$directoryOutput);
    Severity: Minor
    Found in Generator/RestGenerator.php by phan

    Unused definition of variable $subResource (Did you mean $subResources)
    Open

                    foreach ($subResources as $subResource) {
    Severity: Minor
    Found in Generator/RestGenerator.php by phan

    Saw unextractable annotation for comment '* @return [type] [description]'
    Open

         * @return [type] [description]
    Severity: Info
    Found in Generator/RestGenerator.php by phan

    Unused definition of variable $infoSecuritySchema
    Open

                $infoSecuritySchema = $this->apiDef->getSecuredBy(); // descrive i vari security schema usati nelle varie risorse
    Severity: Minor
    Found in Generator/RestGenerator.php by phan

    FIXME found
    Open

                            $routing[$entryName]['requirements'][] = 'FIXME';
    Severity: Minor
    Found in Generator/RestGenerator.php by fixme

    Saw unextractable annotation for comment '* @param [type] $str [description]'
    Open

         * @param [type] $str [description]
    Severity: Info
    Found in Generator/RestGenerator.php by phan

    Possibly zero references to public method \Yoghi\Bundle\MaddaBundle\Generator\RestGenerator::generateRest()
    Open

        public function generateRest($ramlFile, Local $directoryOutput)
    Severity: Minor
    Found in Generator/RestGenerator.php by phan

    Blank line found at start of control structure
    Open

            try {
    Severity: Minor
    Found in Generator/RestGenerator.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status