yoichiro/chrome_mysql_admin

Function editColumn has 72 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    $scope.editColumn = function() {
        if ($scope.type === "SET" || $scope.type === "ENUM") {
            if ($scope.setEnumValues.length === 0) {
                $scope.errorMessage = "SET/ENUM type column must have one or more values.";
                return;

File edit_column_dialog_controller.js has 262 lines of code (exceeds 250 allowed). Consider refactoring.

Open

chromeMyAdmin.controller("EditColumnDialogController", function(
    $scope,
    Events,
    mySQLClientService,
    $q,

Function onShowDialog has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    var onShowDialog = function(table, columnDefs, columnStructure) {
        resetErrorMessage();
        $scope.selectedTable = table;
        $scope.originalColumnDefs = columnDefs;
        $scope.originalColumnStructure = columnStructure;

Similar blocks of code found in 8 locations. Consider refactoring.

Open

        mySQLClientService.query(sql).then(function(result) {
            if (result.hasResultsetRows) {
                $scope.fatalErrorOccurred("Editing column failed.");
            } else {
                $("#editColumnDialog").modal("hide");

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    var getTypeName = function(type) {
        var result = "";
        var b = type.indexOf("(");
        var s = type.indexOf(" ");
        if (b !== -1) {

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        if ($scope.defaultValue) {
            if (typeService.isNumeric($scope.type)
                || $scope.type == 'TIMESTAMP' && $scope.defaultValue == "CURRENT_TIMESTAMP"
            ) {
                sql += "DEFAULT " + $scope.defaultValue + " ";

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        if ($scope.extra !== "NONE") {
            sql += $scope.extra;
            if ($scope.extra === "AUTO_INCREMENT") {
                if ($scope.key === "PRIMARY") {
                    sql += " PRIMARY KEY";

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    var setupItems = function() {
        $scope.types = typeService.getTypes();
        $scope.type = "VARCHAR";
        $scope.extras = ["NONE", "AUTO_INCREMENT",
                         "ON UPDATE CURRENT_TIMESTAMP", "SERIAL DEFAULT VALUE"];

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    $scope.addSetEnumValue = function() {
        if ($scope.setEnumValue && $scope.setEnumValues.indexOf($scope.setEnumValue) === -1) {
            $scope.setEnumValues.push($scope.setEnumValue);
        }
        $scope.setEnumValue = "";

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    $scope.deleteSetEnumValue = function(value) {
        var index = $scope.setEnumValues.indexOf(value);
        if (index !== -1) {
            $scope.setEnumValues.splice(index, 1);
        }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        if ($scope.type === "SET" || $scope.type === "ENUM") {
            if ($scope.setEnumValues.length === 0) {
                $scope.errorMessage = "SET/ENUM type column must have one or more values.";
                return;
            }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        if (typeService.isString($scope.type)) {
            sql += "CHARACTER SET " + $scope.characterSet + " ";
            sql += "COLLATE " + $scope.collation + " ";
            if ($scope.binary) {
                sql += "BINARY ";

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        if ($scope.type === "SET" || $scope.type === "ENUM") {
            sql += "(" + sqlExpressionService.createStringArray($scope.setEnumValues) + ")";
        }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        if (!$scope.allowNull) {
            sql += "NOT NULL ";
        } else if ($scope.type == 'TIMESTAMP' && $scope.allowNull) {
            sql += "NULL ";
        }

• Read up
  Read up