yoichiro/chrome_mysql_admin

View on GitHub

Showing 375 of 375 total issues

File encoding.js has 1859 lines of code (exceeds 250 allowed). Consider refactoring.
Open

(function(global) {
  'use strict';

  //
  // Utilities
Severity: Major
Found in app/scripts/lib/encoding.js - About 5 days to fix

    Function controller has 352 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            controller: ["$scope", function($scope) {
                $scope.drawModel = function(model, element) {
                    if ($scope.positionProvider) {
                        $scope.positionProvider({
                            model: model,
    Severity: Major
    Found in app/scripts/window/directives/er_diagram.js - About 1 day to fix

      File er_diagram.js has 582 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      (function() {
          "use strict";
      
          // --- Model
      
      
      Severity: Major
      Found in app/scripts/window/directives/er_diagram.js - About 1 day to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          function TextDecoder(opt_encoding, options) {
            if (!this || this === global) {
              return new TextDecoder(opt_encoding, options);
            }
            opt_encoding = opt_encoding ? String(opt_encoding) : DEFAULT_ENCODING;
        Severity: Major
        Found in app/scripts/lib/encoding.js and 1 other location - About 1 day to fix
        app/scripts/lib/encoding.js on lines 2260..2284

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 209.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          function TextEncoder(opt_encoding, options) {
            if (!this || this === global) {
              return new TextEncoder(opt_encoding, options);
            }
            opt_encoding = opt_encoding ? String(opt_encoding) : DEFAULT_ENCODING;
        Severity: Major
        Found in app/scripts/lib/encoding.js and 1 other location - About 1 day to fix
        app/scripts/lib/encoding.js on lines 2324..2348

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 209.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function exports has 197 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        module.exports = function (grunt) {
            // show elapsed time at the end
            require('time-grunt')(grunt);
            // load all grunt tasks
            require('load-grunt-tasks')(grunt);
        Severity: Major
        Found in Gruntfile.js - About 7 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              $scope.findSameRows = function() {
                  mySQLQueryService.showTables().then(function(result) {
                      var resultsetRows = result.resultsetRows;
                      var tables = [];
                      angular.forEach(resultsetRows, function(resultsetRow) {
          app/scripts/window/controllers/find_rows_with_the_value_dialog_controller.js on lines 119..133

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 162.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              $scope.findRowsWithTheValue = function() {
                  mySQLQueryService.showTables().then(function(result) {
                      var resultsetRows = result.resultsetRows;
                      var tables = [];
                      angular.forEach(resultsetRows, function(resultsetRow) {
          app/scripts/window/controllers/find_same_rows_dialog_controller.js on lines 142..156

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 162.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          File rows_panel_controller.js has 425 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          chromeMyAdmin.controller("RowsPanelController", function(
              $scope,
              mySQLClientService,
              modeService,
              targetObjectService,
          Severity: Minor
          Found in app/scripts/window/controllers/rows_panel_controller.js - About 6 hrs to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                var createCreateTable = function(table, ddl) {
                    var result = [];
                    result.push("--");
                    result.push("-- Table structure for table `" + table + "`");
                    result.push("--");
            Severity: Major
            Found in app/scripts/window/services/export_all_databases_service.js and 1 other location - About 5 hrs to fix
            app/scripts/window/services/export_all_databases_service.js on lines 268..280

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 152.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                var createCreateView = function(table, ddl) {
                    var result = [];
                    result.push("--");
                    result.push("-- View structure for view `" + table + "`");
                    result.push("--");
            Severity: Major
            Found in app/scripts/window/services/export_all_databases_service.js and 1 other location - About 5 hrs to fix
            app/scripts/window/services/export_all_databases_service.js on lines 254..266

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 152.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                var initializeIndexesGrid = function() {
                    resetIndexesGrid();
                    $scope.indexesGrid = {
                        data: "indexesData",
                        columnDefs: "indexesColumnDefs",
            Severity: Major
            Found in app/scripts/window/controllers/structure_panel_controller.js and 1 other location - About 5 hrs to fix
            app/scripts/window/controllers/structure_panel_controller.js on lines 17..37

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 146.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                var initializeStructureGrid = function() {
                    resetStructureGrid();
                    $scope.structureGrid = {
                        data: "structureData",
                        columnDefs: "structureColumnDefs",
            Severity: Major
            Found in app/scripts/window/controllers/structure_panel_controller.js and 1 other location - About 5 hrs to fix
            app/scripts/window/controllers/structure_panel_controller.js on lines 39..59

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 146.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                var deleteIndex = function() {
                    var table = targetObjectService.getTable().name;
                    var indexName = $scope.selectedIndex.Key_name;
                    var sql = "DROP INDEX `" + indexName + "` ON `" + table + "`";
                    mySQLClientService.query(sql).then(function(result) {
            Severity: Major
            Found in app/scripts/window/controllers/structure_panel_controller.js and 1 other location - About 5 hrs to fix
            app/scripts/window/controllers/structure_panel_controller.js on lines 203..216

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 145.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                var deleteColumn = function() {
                    var table = targetObjectService.getTable().name;
                    var column = $scope.selectedColumn.Field;
                    var sql = "ALTER TABLE `" + table + "` DROP COLUMN `" + column + "`";
                    mySQLClientService.query(sql).then(function(result) {
            Severity: Major
            Found in app/scripts/window/controllers/structure_panel_controller.js and 1 other location - About 5 hrs to fix
            app/scripts/window/controllers/structure_panel_controller.js on lines 218..231

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 145.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    showCollations: function() {
                        var deferred = $q.defer();
                        mySQLClientService.query("SHOW COLLATION").then(function(result) {
                            if (result.hasResultsetRows) {
                                if (result.resultsetRows.length > 0) {
            Severity: Major
            Found in app/scripts/window/services/mysql_query_service.js and 1 other location - About 5 hrs to fix
            app/scripts/window/services/mysql_query_service.js on lines 9..25

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 145.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    showCharacterSet: function() {
                        var deferred = $q.defer();
                        mySQLClientService.query("SHOW CHARACTER SET").then(function(result) {
                            if (result.hasResultsetRows) {
                                if (result.resultsetRows.length > 0) {
            Severity: Major
            Found in app/scripts/window/services/mysql_query_service.js and 1 other location - About 5 hrs to fix
            app/scripts/window/services/mysql_query_service.js on lines 26..42

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 145.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 8 locations. Consider refactoring.
            Open

                        mySQLClientService.query(sql).then(function(result) {
                            if (result.hasResultsetRows) {
                                $scope.fatalErrorOccurred("Inserting row failed.");
                            } else {
                                $("#insertRowDialog").modal("hide");
            app/scripts/window/controllers/add_column_dialog_controller.js on lines 136..149
            app/scripts/window/controllers/add_index_dialog_controller.js on lines 123..136
            app/scripts/window/controllers/add_relation_dialog_controller.js on lines 141..154
            app/scripts/window/controllers/create_database_dialog_controller.js on lines 38..51
            app/scripts/window/controllers/create_routine_dialog_controller.js on lines 112..125
            app/scripts/window/controllers/edit_column_dialog_controller.js on lines 244..257
            app/scripts/window/controllers/update_row_dialog_controller.js on lines 101..114

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 142.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 8 locations. Consider refactoring.
            Open

                    mySQLClientService.query(sql).then(function(result) {
                        if (result.hasResultsetRows) {
                            $scope.fatalErrorOccurred("Adding relation failed.");
                        } else {
                            $("#addRelationDialog").modal("hide");
            app/scripts/window/controllers/add_column_dialog_controller.js on lines 136..149
            app/scripts/window/controllers/add_index_dialog_controller.js on lines 123..136
            app/scripts/window/controllers/create_database_dialog_controller.js on lines 38..51
            app/scripts/window/controllers/create_routine_dialog_controller.js on lines 112..125
            app/scripts/window/controllers/edit_column_dialog_controller.js on lines 244..257
            app/scripts/window/controllers/insert_row_dialog_controller.js on lines 86..99
            app/scripts/window/controllers/update_row_dialog_controller.js on lines 101..114

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 142.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 8 locations. Consider refactoring.
            Open

                    mySQLClientService.query(sql).then(function(result) {
                        if (result.hasResultsetRows) {
                            $scope.fatalErrorOccurred("Editing column failed.");
                        } else {
                            $("#editColumnDialog").modal("hide");
            app/scripts/window/controllers/add_column_dialog_controller.js on lines 136..149
            app/scripts/window/controllers/add_index_dialog_controller.js on lines 123..136
            app/scripts/window/controllers/add_relation_dialog_controller.js on lines 141..154
            app/scripts/window/controllers/create_database_dialog_controller.js on lines 38..51
            app/scripts/window/controllers/create_routine_dialog_controller.js on lines 112..125
            app/scripts/window/controllers/insert_row_dialog_controller.js on lines 86..99
            app/scripts/window/controllers/update_row_dialog_controller.js on lines 101..114

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 142.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language