Sign upLogin

yoichiro/chrome_mysql_admin

View on GitHub
Star
app/scripts/window/controllers/login_form_controller.js

Summary

Maintainability
D
2 days
Test Coverage

File login_form_controller.js has 283 lines of code (exceeds 250 allowed). Consider refactoring.
Open

chromeMyAdmin.controller("LoginFormController", function(
    $scope,
    $timeout,
    mySQLClientService,
    favoriteService,
Severity: Minor
Found in app/scripts/window/controllers/login_form_controller.js - About 2 hrs to fix

    Function startPortForwarding has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        var startPortForwarding = function(event) {
        var hostName = $scope.ssh2HostName;
        var port = $scope.ssh2PortNumber;
        ssh2PortForwardingService.connect(hostName, port).then(function(result) {
            var fingerprint = result.values[0];
    Severity: Minor
    Found in app/scripts/window/controllers/login_form_controller.js - About 1 hr to fix

      Function assignEventHandlers has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          var assignEventHandlers = function() {
        $scope.$on(Events.FAVORITE_SELECTED, function(event, favorite) {
            $scope.safeApply(function() {
                $scope.name = favorite.name;
                $scope.hostName = favorite.hostName;
      Severity: Minor
      Found in app/scripts/window/controllers/login_form_controller.js - About 1 hr to fix

        Function doConnectToMySQL has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            var doConnectToMySQL = function(hostName, portNumber) {
        if (isUseSSLConnection()) {
            mySQLClientService.loginWithSSL(
                hostName,
                Number(portNumber),
        Severity: Minor
        Found in app/scripts/window/controllers/login_form_controller.js - About 1 hr to fix

          Function doTestConnectToMySQL has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              var doTestConnectToMySQL = function(hostName, portNumber) {
        if (isUseSSLConnection()) {
            mySQLClientService.loginWithSSL(
                hostName,
                Number(portNumber),
          Severity: Minor
          Found in app/scripts/window/controllers/login_form_controller.js - About 1 hr to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        mySQLClientService.loginWithSSL(
                hostName,
                Number(portNumber),
                $scope.userName,
                $scope.password,
            Severity: Major
            Found in app/scripts/window/controllers/login_form_controller.js and 1 other location - About 1 hr to fix
            app/scripts/window/controllers/login_form_controller.js on lines 147..159

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 74.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        mySQLClientService.login(
                hostName,
                Number(portNumber),
                $scope.userName,
                $scope.password
            Severity: Major
            Found in app/scripts/window/controllers/login_form_controller.js and 1 other location - About 1 hr to fix
            app/scripts/window/controllers/login_form_controller.js on lines 131..145

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 74.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    $scope.$on(Events.CONTINUE_SSH2_PORT_FORWARDING_FOR_TEST, function(event, data) {
            ssh2KnownHostService.addLastChecked().then(function(result) {
                continueSsh2PortForwarding(function(port) {
                    doTestConnectToMySQL("127.0.0.1", port);
                });
            Severity: Major
            Found in app/scripts/window/controllers/login_form_controller.js and 1 other location - About 1 hr to fix
            app/scripts/window/controllers/login_form_controller.js on lines 68..74

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 68.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    $scope.$on(Events.CONTINUE_SSH2_PORT_FORWARDING, function(event, data) {
            ssh2KnownHostService.addLastChecked().then(function(result) {
                continueSsh2PortForwarding(function(port) {
                    doConnectToMySQL("127.0.0.1", port);
                });
            Severity: Major
            Found in app/scripts/window/controllers/login_form_controller.js and 1 other location - About 1 hr to fix
            app/scripts/window/controllers/login_form_controller.js on lines 75..81

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 68.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                var adjustLoginFormHeight = function() {
        $("#loginForm").height(
            $(window).height() -
                UIConstants.WINDOW_TITLE_PANEL_HEIGHT -
                UIConstants.NAVBAR_HEIGHT -
            Severity: Major
            Found in app/scripts/window/controllers/login_form_controller.js and 3 other locations - About 1 hr to fix
            app/scripts/window/controllers/er_diagram_panel_controller.js on lines 178..184
            app/scripts/window/controllers/relation_panel_controller.js on lines 66..72
            app/scripts/window/main.js on lines 127..133

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 62.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        mySQLClientService.login(
                hostName,
                Number(portNumber),
                $scope.userName,
                $scope.password
            Severity: Major
            Found in app/scripts/window/controllers/login_form_controller.js and 1 other location - About 1 hr to fix
            app/scripts/window/controllers/login_form_controller.js on lines 99..112

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        mySQLClientService.loginWithSSL(
                hostName,
                Number(portNumber),
                $scope.userName,
                $scope.password,
            Severity: Major
            Found in app/scripts/window/controllers/login_form_controller.js and 1 other location - About 1 hr to fix
            app/scripts/window/controllers/login_form_controller.js on lines 114..125

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                $scope.doTestConnection = function() {
        if (isUsePortForwarding()) {
            startPortForwarding(Events.CONTINUE_SSH2_PORT_FORWARDING_FOR_TEST);
        } else {
            doTestConnectToMySQL($scope.hostName, $scope.portNumber);
            Severity: Minor
            Found in app/scripts/window/controllers/login_form_controller.js and 1 other location - About 35 mins to fix
            app/scripts/window/controllers/login_form_controller.js on lines 163..169

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                var doConnect = function() {
        if (isUsePortForwarding()) {
            startPortForwarding(Events.CONTINUE_SSH2_PORT_FORWARDING);
        } else {
            doConnectToMySQL($scope.hostName, $scope.portNumber);
            Severity: Minor
            Found in app/scripts/window/controllers/login_form_controller.js and 1 other location - About 35 mins to fix
            app/scripts/window/controllers/login_form_controller.js on lines 248..254

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status