Sign upLogin

yoichiro/chrome_mysql_admin

View on GitHub
Star
app/scripts/window/controllers/procedures_functions_panel_controller.js

Summary

Maintainability
D
2 days
Test Coverage

File procedures_functions_panel_controller.js has 315 lines of code (exceeds 250 allowed). Consider refactoring.
Open

chromeMyAdmin.controller("ProceduresFunctionsPanelController", function(
    $scope,
    mySQLClientService,
    modeService,
    targetObjectService,
Severity: Minor
Found in app/scripts/window/controllers/procedures_functions_panel_controller.js - About 3 hrs to fix

    Function getProcedureParameters has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        var getProcedureParameters = function(routineCode) {
        var start = routineCode.indexOf("(") + 1;
        var cnt = 0;
        var end = -1;
        for (var i = start; i < routineCode.length; i++) {
    Severity: Minor
    Found in app/scripts/window/controllers/procedures_functions_panel_controller.js - About 1 hr to fix

      Function executeProcedure has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          var executeProcedure = function(selectedRoutine) {
        if (selectedRoutine.entity.ROUTINE_TYPE !== "PROCEDURE") {
            return;
        }
        getRoutineCode(selectedRoutine).then(function(routineCode) {
      Severity: Minor
      Found in app/scripts/window/controllers/procedures_functions_panel_controller.js - About 1 hr to fix

        Function assignEventHandlers has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            var assignEventHandlers = function() {
        $scope.$on(Events.CONNECTION_CHANGED, function(event, data) {
            onConnectionChanged();
        });
        $scope.$on(Events.DATABASE_CHANGED, function(event, database) {
        Severity: Minor
        Found in app/scripts/window/controllers/procedures_functions_panel_controller.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              var updateRoutinesColumnDefs = function(columnDefinitions) {
        var columnDefs = [];
        angular.forEach(columnDefinitions, function(columnDefinition) {
            this.push({
                field: columnDefinition.orgName,
          Severity: Major
          Found in app/scripts/window/controllers/procedures_functions_panel_controller.js and 1 other location - About 4 hrs to fix
          app/scripts/window/controllers/structure_panel_controller.js on lines 102..116

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 133.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              var initializeRoutinesGrid = function() {
        resetRoutinesGrid();
        $scope.routinesGrid = {
            data: "routinesData",
            columnDefs: "routinesColumnDefs",
          Severity: Major
          Found in app/scripts/window/controllers/procedures_functions_panel_controller.js and 1 other location - About 4 hrs to fix
          app/scripts/window/controllers/relation_panel_controller.js on lines 16..35

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 130.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              $scope.aceLoaded = function(editor) {
        $scope.editor = editor;
        editor.setHighlightActiveLine(false);
        editor.setShowPrintMargin(false);
        editor.setShowInvisibles(true);
          Severity: Major
          Found in app/scripts/window/controllers/procedures_functions_panel_controller.js and 1 other location - About 2 hrs to fix
          app/scripts/window/controllers/information_panel_controller.js on lines 177..184

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 90.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              var adjustRoutinesPanelHeight = function() {
        $("#routinesGrid").height(
            ($(window).height() -
             UIConstants.WINDOW_TITLE_PANEL_HEIGHT -
             UIConstants.NAVBAR_HEIGHT -
          Severity: Major
          Found in app/scripts/window/controllers/procedures_functions_panel_controller.js and 2 other locations - About 1 hr to fix
          app/scripts/window/controllers/rows_panel_controller.js on lines 95..101
          app/scripts/window/controllers/status_graph_panel_controller.js on lines 56..62

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 66.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              $scope.initialize = function() {
        initializeRoutinesGrid();
        assignWindowResizeEventHandler();
        adjustRoutinesPanelHeight();
        adjustRoutineCodeEditorHeight();
          Severity: Minor
          Found in app/scripts/window/controllers/procedures_functions_panel_controller.js and 1 other location - About 35 mins to fix
          app/scripts/window/controllers/rows_panel_controller.js on lines 437..443

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              var assignWindowResizeEventHandler = function() {
        $(window).resize(function(evt) {
            adjustRoutinesPanelHeight();
            adjustRoutineCodeEditorHeight();
        });
          Severity: Minor
          Found in app/scripts/window/controllers/procedures_functions_panel_controller.js and 1 other location - About 30 mins to fix
          app/scripts/window/controllers/structure_panel_controller.js on lines 78..83

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status