Sign upLogin

yoichiro/chrome_mysql_admin

View on GitHub
Star
app/scripts/window/controllers/update_row_dialog_controller.js

Summary

Maintainability
C
1 day
Test Coverage

Function updateRow has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    $scope.updateRow = function() {
        resetErrorMessage();
        var sql = "UPDATE `" + targetObjectService.getTable().name + "` ";
        var sets = [];
        angular.forEach($scope.values, function(value, columnName) {
Severity: Minor
Found in app/scripts/window/controllers/update_row_dialog_controller.js - About 1 hr to fix

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

                mySQLClientService.query(sql).then(function(result) {
                if (result.hasResultsetRows) {
                    $scope.fatalErrorOccurred("Updating row failed.");
                } else {
                    $("#updateRowDialog").modal("hide");
    Severity: Major
    Found in app/scripts/window/controllers/update_row_dialog_controller.js and 7 other locations - About 5 hrs to fix
    app/scripts/window/controllers/add_column_dialog_controller.js on lines 136..149
    app/scripts/window/controllers/add_index_dialog_controller.js on lines 123..136
    app/scripts/window/controllers/add_relation_dialog_controller.js on lines 141..154
    app/scripts/window/controllers/create_database_dialog_controller.js on lines 38..51
    app/scripts/window/controllers/create_routine_dialog_controller.js on lines 112..125
    app/scripts/window/controllers/edit_column_dialog_controller.js on lines 244..257
    app/scripts/window/controllers/insert_row_dialog_controller.js on lines 86..99

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 142.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        $scope.onChangeValueType = function(columnName) {
        var valueType = $scope.valueTypes[columnName];
        if (valueType !== ValueTypes.NULL) {
            var value = $scope.values[columnName];
            if (!value) {
    Severity: Major
    Found in app/scripts/window/controllers/update_row_dialog_controller.js and 1 other location - About 2 hrs to fix
    app/scripts/window/controllers/insert_row_dialog_controller.js on lines 105..113

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 86.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        $scope.targetInputColumns = function() {
        var result = [];
        angular.forEach($scope.columnDefinitions, function(column) {
            // TODO filter
            result.push(column);
    Severity: Major
    Found in app/scripts/window/controllers/update_row_dialog_controller.js and 1 other location - About 1 hr to fix
    app/scripts/window/controllers/insert_row_dialog_controller.js on lines 63..70

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                if (value === null) {
                $scope.valueTypes[column.name] = ValueTypes.NULL;
            } else {
                $scope.valueTypes[column.name] = ValueTypes.VALUE;
            }
    Severity: Major
    Found in app/scripts/window/controllers/update_row_dialog_controller.js and 1 other location - About 1 hr to fix
    app/scripts/window/controllers/insert_row_dialog_controller.js on lines 35..39

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status