Sign upLogin

yoichiro/chrome_mysql_admin

View on GitHub
Star
app/scripts/window/services/mysql_client_service.js

Summary

Maintainability
D
2 days
Test Coverage

File mysql_client_service.js has 291 lines of code (exceeds 250 allowed). Consider refactoring.
Open

chromeMyAdmin.factory("mySQLClientService", function(
    $q,
    $rootScope
) {
    "use strict";
Severity: Minor
Found in app/scripts/window/services/mysql_client_service.js - About 3 hrs to fix

    Function _doQuery has 59 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        var _doQuery = function(task, showProgressBar) {
        if (showProgressBar) {
            $rootScope.showMainStatusMessage("Executing query...");
            $rootScope.showProgressBar();
        }
    Severity: Major
    Found in app/scripts/window/services/mysql_client_service.js - About 2 hrs to fix

      Function loginWithSSL has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              loginWithSSL: function(hostName, portNumber, userName, password, ca, checkCN) {
            $rootScope.showMainStatusMessage("Logging in to MySQL server with SSL...");
            $rootScope.showProgressBar();
            var deferred = $q.defer();
            $rootScope.notifyExecutingQuery("Logging in to MySQL server with SSL.");
      Severity: Minor
      Found in app/scripts/window/services/mysql_client_service.js - About 1 hr to fix

        Function login has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                login: function(hostName, portNumber, userName, password) {
            $rootScope.showMainStatusMessage("Logging in to MySQL server...");
            $rootScope.showProgressBar();
            var deferred = $q.defer();
            $rootScope.notifyExecutingQuery("Logging in to MySQL server.");
        Severity: Minor
        Found in app/scripts/window/services/mysql_client_service.js - About 1 hr to fix

          Function loginWithSSL has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  loginWithSSL: function(hostName, portNumber, userName, password, ca, checkCN) {
          Severity: Minor
          Found in app/scripts/window/services/mysql_client_service.js - About 45 mins to fix

            Avoid too many return statements within this function.
            Open

                        return _doPing(task);
            Severity: Major
            Found in app/scripts/window/services/mysql_client_service.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return null;
              Severity: Major
              Found in app/scripts/window/services/mysql_client_service.js - About 30 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        mySQLClient.getDatabases(function(databases) {
            $rootScope.hideProgressBar();
            $rootScope.showMainStatusMessage("Retrieved database list.");
            queryQueue.shift();
            var remaining = queryQueue.length;
                Severity: Major
                Found in app/scripts/window/services/mysql_client_service.js and 1 other location - About 2 hrs to fix
                app/scripts/window/services/mysql_client_service.js on lines 166..175

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 81.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        mySQLClient.getStatistics(function(statistics) {
            $rootScope.hideProgressBar();
            $rootScope.showMainStatusMessage("Retrieved statistics.");
            queryQueue.shift();
            var remaining = queryQueue.length;
                Severity: Major
                Found in app/scripts/window/services/mysql_client_service.js and 1 other location - About 2 hrs to fix
                app/scripts/window/services/mysql_client_service.js on lines 138..147

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 81.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                function(initialHandshakeRequest, result) {
                    $rootScope.hideProgressBar();
                    if (result.isSuccess()) {
                        $rootScope.showMainStatusMessage("Logged in to MySQL server with SSL.");
                        deferred.resolve(initialHandshakeRequest);
                Severity: Major
                Found in app/scripts/window/services/mysql_client_service.js and 1 other location - About 2 hrs to fix
                app/scripts/window/services/mysql_client_service.js on lines 228..237

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 79.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                function(initialHandshakeRequest, result) {
                    $rootScope.hideProgressBar();
                    if (result.isSuccess()) {
                        $rootScope.showMainStatusMessage("Logged in to MySQL server.");
                        deferred.resolve(initialHandshakeRequest);
                Severity: Major
                Found in app/scripts/window/services/mysql_client_service.js and 1 other location - About 2 hrs to fix
                app/scripts/window/services/mysql_client_service.js on lines 262..271

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 79.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status