Sign upLogin

yourkarma/JWT

View on GitHub
Star

Showing 18 of 18 total issues

Class KeysGenerator has 30 methods (exceeds 20 allowed). Consider refactoring.
Open

class KeysGenerator
    module FileFormatsModule
        def only_name(name)
            # remove extension
            Pathname.new(name).basename
Severity: Minor
Found in Scripts/generate_ec_curved_keys.rb - About 3 hrs to fix

    File generate_ec_curved_keys.rb has 287 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'optparse'
require 'shellwords'
require 'pathname'
class ShellExecutor
    @@dry_run = false
    Severity: Minor
    Found in Scripts/generate_ec_curved_keys.rb - About 2 hrs to fix

      Function decode has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          func decode(token: String?, object: TokenDecoderDataTransferObjectProtocol) -> JWTCodingResultType? {
        print("JWT ENCODED TOKEN \(String(describing: token))")
        let algorithmName = object.algorithmName
        let skipVerification = object.shouldSkipSignatureVerification
        print("JWT Algorithm NAME \(algorithmName)")
      Severity: Minor
      Found in Example/JWTDesktopSwiftToolkit/Sources/JWTDesktopSwiftToolkit/TokenDecoder.swift - About 2 hrs to fix

        Function reloadData has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            func reloadData() {
        self.cachedResultArray = nil
        self.cachedErrorDictionary = nil
        if let resultType = self.resultType {
            if let successResult = resultType.successResult, let dictionary = successResult.headerAndPayloadDictionary {
        Severity: Minor
        Found in Example/JWTDesktopSwift/JWTDesktopSwift/DecriptedViewController.swift - About 1 hr to fix

          Function decode has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              func decode(token: String?, object: TokenDecoderDataTransferObjectProtocol) -> JWTCodingResultType? {
        print("JWT ENCODED TOKEN \(String(describing: token))")
        let algorithmName = object.algorithmName
        let skipVerification = object.shouldSkipSignatureVerification
        print("JWT Algorithm NAME \(algorithmName)")
          Severity: Minor
          Found in Example/JWTDesktopSwiftToolkit/Sources/JWTDesktopSwiftToolkit/TokenDecoder.swift - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method generated has 8 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def generated(type, parameters, private_key_pem, public_key_pem, certificate_request, certificate, p12, p12_password)
          Severity: Major
          Found in Scripts/generate_ec_curved_keys.rb - About 1 hr to fix

            Function reloadData has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                func reloadData() {
        self.cachedResultArray = nil
        self.cachedErrorDictionary = nil
        if let resultType = self.resultType {
            if let successResult = resultType.successResult, let dictionary = successResult.headerAndPayloadDictionary {
            Severity: Minor
            Found in Example/JWTDesktopSwift/JWTDesktopSwift/DecriptedViewController.swift - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function decode has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                func decode(token: String?, object: TokenDecoderDataTransferObjectProtocol) -> JWTCodingResultType? {
        // do work here.
        print("JWT ENCODED TOKEN \(String(describing: token))")
        let algorithmName = object.algorithmName
        let skipVerification = object.shouldSkipSignatureVerification
            Severity: Minor
            Found in Example/JWTDesktopSwiftToolkit/Sources/JWTDesktopSwiftToolkit/TokenDecoder.swift - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    def run_command_line(line)
            puts "I will perform <#{line}>"
            if dry?
                puts "I am on dry run!"
            else
            Severity: Minor
            Found in Scripts/generate_keys.rb and 1 other location - About 40 mins to fix
            Scripts/generate_ec_curved_keys.rb on lines 17..29

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 37.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    def run_command_line(line)
            puts "I will perform \n <#{line}>"
            if dry?
                puts "I am on dry run!"
            else
            Severity: Minor
            Found in Scripts/generate_ec_curved_keys.rb and 1 other location - About 40 mins to fix
            Scripts/generate_keys.rb on lines 23..35

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 37.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                static func HS256() -> Self {
        let algorithmName = JWTAlgorithmNameHS256
        let secret = "c2VjcmV0"
        let token = "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6IkpvaG4gRG9lIiwiYWRtaW4iOnRydWV9.TJVA95OrM7E2cBab30RMHrHDcEfxjoYZgeFONFh7HgQ"
        return self.create(algorithmName: algorithmName, secret: secret, token: token)
            Severity: Minor
            Found in Example/JWTSwiftUI/JWTSwiftUI/JWTModel.swift and 1 other location - About 35 mins to fix
            Example/JWTSwiftUI/JWTSwiftUI/JWTModel.swift on lines 198..203

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                static func RS256() -> Self {
        let algorithmName = JWTAlgorithmNameRS256
        let secret = "-----BEGIN PUBLIC KEY-----MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAoPryo3IisfK3a028bwgso/CW5kB84mk6Y7rO76FxJRTWnOAla0Uf0OpIID7go4Qck66yT4/uPpiOQIR0oW0plTekkDP75EG3d/2mtzhiCtELV4F1r9b/InCN5dYYK8USNkKXgjbeVyatdUvCtokz10/ibNZ9qikgKf58qXnn2anGvpE6ded5FOUEukOjr7KSAfD0KDNYWgZcG7HZBxn/3N7ND9D0ATu2vxlJsNGOkH6WL1EmObo/QygBXzuZm5o0N0W15EXpWVbl4Ye7xqPnvc1i2DTKxNUcyhXfDbLw1ee2d9T/WU5895Ko2bQ/O/zPwUSobM3m+fPMW8kp5914kwIDAQAB-----END PUBLIC KEY-----"
        let token = "eyJraWQiOiJqd3RfdWF0X2tleXMiLCJ0eXAiOiJKV1QiLCJhbGciOiJSUzI1NiJ9.eyJzdWIiOiI1MDAxIiwiaXNzIjoiQ0xNIiwiZXhwIjoxNTA4MjQ5NTU3LCJqdGkiOiI2MjcyM2E4Yi0zOTZmLTQxYmYtOTljMi02NWRkMzk2MDNiNjQifQ.Cej8RJ6e2HEU27rh_TyHZBoMI1jErmhOfSFY4SRzRoijSP628hM82XxjDX24HsKqIsK1xeeGI1yg1bed4RPhnmDGt4jAY73nqguZ1oqZ2DTcfZ5olxCXyLLaytl2XH7-62M_mFUcGj7I2mwts1DQkHWnFky2i4uJXlksHFkUg2xZoGEjVHo0bxCxgQ5yQiOpxC5VodN5rAPM3A5yMG6EijOp-dvUThjoJ4RFTGKozw_x_Qg6RLGDusNcmLIMbHasTsyZAZle6RFkwO0Sij1k6z6_xssbOl-Q57m7CeYgVHMORdzy4Smkmh-0gzeiLsGbCL4fhgdHydpIFajW-eOXMw"
        return self.create(algorithmName: algorithmName, secret: secret, token: token)
            Severity: Minor
            Found in Example/JWTSwiftUI/JWTSwiftUI/JWTModel.swift and 1 other location - About 35 mins to fix
            Example/JWTSwiftUI/JWTSwiftUI/JWTModel.swift on lines 191..196

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method fix_options has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                def fix_options(the_options)
        options = the_options
        options[:result_directory] ||= '../Tests/Resources/Certs/'
        if options[:test]
            options[:algorithm_type] ||= KeyParameters::TYPES.first
            Severity: Minor
            Found in Scripts/generate_keys.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            //
//  ViewController+Model.swift
//  JWTDesktopSwift
//
//  Created by Lobanov Dmitry on 30.10.2017.
            Severity: Minor
            Found in Example/JWTDesktopSwift/JWTDesktopSwift/ViewController+Model.swift and 1 other location - About 30 mins to fix
            Example/JWTDesktopSwift/JWTDesktopSwift/ViewController+Model.swift on lines 1..55

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 42.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Avoid too many return statements within this function.
            Open

                        return nil
            Severity: Major
            Found in Example/JWTDesktopSwiftToolkit/Sources/JWTDesktopSwiftToolkit/TokenDecoder.swift - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return string
              Severity: Major
              Found in Example/JWTDesktopSwiftToolkit/Sources/JWTDesktopSwiftToolkit/String+Extension.swift - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            return result
                Severity: Major
                Found in Example/JWTDesktopSwiftToolkit/Sources/JWTDesktopSwiftToolkit/TokenDecoder.swift - About 30 mins to fix

                  Method generated has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def generated(type, parameters, private_key_pem, public_key_pem, certificate_request, certificate, p12, p12_password)
        the_private_key_pem ||= FileFormats.to_pem private_key_pem
        the_public_key_pem ||= FileFormats.to_pem public_key_pem
        the_certificate_request ||= FileFormats.to_certificate_request certificate_request
        the_certificate ||= FileFormats.to_certificate certificate
                  Severity: Minor
                  Found in Scripts/generate_ec_curved_keys.rb - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language