Sign upLogin

yoyo-project/yoyo

View on GitHub
Star
internal/schema/schema_validate.go

Summary

Maintainability
B
6 hrs
Test Coverage

Method Database.validate has a Cognitive Complexity of 35 (exceeds 20 allowed). Consider refactoring.
Open

func (db *Database) validate() (err error) {
    tNames := make(map[string]bool)
    for _, t := range db.Tables {
        if err = t.validate(); err != nil {
            return fmt.Errorf("%w for table `%s`", err, t.Name)
Severity: Minor
Found in internal/schema/schema_validate.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Table.validate has a Cognitive Complexity of 26 (exceeds 20 allowed). Consider refactoring.
Open

func (t *Table) validate() (err error) {
    if err = validateName(t.Name); err != nil {
        return err
    }
Severity: Minor
Found in internal/schema/schema_validate.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Table.validate has 8 return statements (exceeds 4 allowed).
Open

func (t *Table) validate() (err error) {
    if err = validateName(t.Name); err != nil {
        return err
    }
Severity: Major
Found in internal/schema/schema_validate.go - About 50 mins to fix

    Method Column.validate has 8 return statements (exceeds 4 allowed).
    Open

    func (c *Column) validate() error {
    if err := validateName(c.Name); err != nil {
        return err
    }
    Severity: Major
    Found in internal/schema/schema_validate.go - About 50 mins to fix

      Method Database.validate has 6 return statements (exceeds 4 allowed).
      Open

      func (db *Database) validate() (err error) {
    tNames := make(map[string]bool)
    for _, t := range db.Tables {
        if err = t.validate(); err != nil {
            return fmt.Errorf("%w for table `%s`", err, t.Name)
      Severity: Major
      Found in internal/schema/schema_validate.go - About 40 mins to fix

        Method Reference.validate has 5 return statements (exceeds 4 allowed).
        Open

        func (r *Reference) validate() error {
    if err := validateName(r.GoName); err != nil {
        return err
    }
    if r.HasMany == r.HasOne {
        Severity: Major
        Found in internal/schema/schema_validate.go - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status