Sign upLogin

ysiadf/AllIncomeFoods

View on GitHub
Star

Showing 12 of 12 total issues

Function sendFarmersMarketRequestForCoordinate has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

    func sendFarmersMarketRequestForCoordinate(coordinate: CLLocationCoordinate2D) {
        if CLLocationCoordinate2DIsValid(coordinate) {
            let urlString = NSString(format: "%@%@y=%f&x=%f&SNAP=1", Constants.kUSDABaseURL, Constants.kUSDAFarmersMarketSearchEndpoint, coordinate.latitude, coordinate.longitude)
            let url = NSURL(string: urlString as String)
            let request = NSURLRequest(URL: url!)
Severity: Minor
Found in iOS/SnapFresh/Controllers/RequestController.swift - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function sendFarmersMarketDetailRequest has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    func sendFarmersMarketDetailRequest(markets: NSArray, completionHandler: (farmersMarkets: NSArray?, error: NSError?) -> Void) {
        if (markets.count == 0) {
            let error = NSError(domain: "com.shrtlist.snapfresh", code:100, userInfo: [NSLocalizedFailureReasonErrorKey : "Empty array"])
            
            completionHandler(farmersMarkets: nil, error: error)
Severity: Minor
Found in iOS/SnapFresh/Controllers/RequestController.swift - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function sendFarmersMarketRequestForCoordinate has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    func sendFarmersMarketRequestForCoordinate(coordinate: CLLocationCoordinate2D) {
        if CLLocationCoordinate2DIsValid(coordinate) {
            let urlString = NSString(format: "%@%@y=%f&x=%f&SNAP=1", Constants.kUSDABaseURL, Constants.kUSDAFarmersMarketSearchEndpoint, coordinate.latitude, coordinate.longitude)
            let url = NSURL(string: urlString as String)
            let request = NSURLRequest(URL: url!)
Severity: Major
Found in iOS/SnapFresh/Controllers/RequestController.swift - About 2 hrs to fix

    Function sendFarmersMarketDetailRequest has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        func sendFarmersMarketDetailRequest(markets: NSArray, completionHandler: (farmersMarkets: NSArray?, error: NSError?) -> Void) {
        if (markets.count == 0) {
            let error = NSError(domain: "com.shrtlist.snapfresh", code:100, userInfo: [NSLocalizedFailureReasonErrorKey : "Empty array"])
            
            completionHandler(farmersMarkets: nil, error: error)
    Severity: Minor
    Found in iOS/SnapFresh/Controllers/RequestController.swift - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          func farmersMarketsDidLoad(notification: NSNotification) {
        farmersMarkets = notification.object as! [FarmersMarket]
        
        NSOperationQueue.mainQueue().addOperation(NSBlockOperation(block: {
            // Reload the data when there are new annotations on the map.
      Severity: Minor
      Found in iOS/SnapFresh/Controllers/ListViewController.swift and 1 other location - About 45 mins to fix
      iOS/SnapFresh/Controllers/ListViewController.swift on lines 61..68

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 57.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          func snapRetailersDidLoad(notification: NSNotification) {
        retailers = notification.object as! [SnapRetailer]
        
        NSOperationQueue.mainQueue().addOperation(NSBlockOperation(block: {
            // Reload the data when there are new annotations on the map.
      Severity: Minor
      Found in iOS/SnapFresh/Controllers/ListViewController.swift and 1 other location - About 45 mins to fix
      iOS/SnapFresh/Controllers/ListViewController.swift on lines 70..77

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 57.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Avoid deeply nested control flow statements.
      Open

                                  if (index == self.kMaxFarmersMarkets) {
                                break
                            }
      Severity: Major
      Found in iOS/SnapFresh/Controllers/RequestController.swift - About 45 mins to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            override var subtitle: String? {
        get {
            let postalAddressString = ABCreateStringWithAddressDictionary(self.addressDictionary!, false)
            return postalAddressString.stringByTrimmingCharactersInSet(NSCharacterSet.newlineCharacterSet())
        }
        Severity: Minor
        Found in iOS/SnapFresh/Model/SnapRetailer.swift and 1 other location - About 40 mins to fix
        iOS/SnapFresh/Model/FarmersMarket.swift on lines 95..101

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            override var subtitle: String? {
        get {
            let postalAddressString = ABCreateStringWithAddressDictionary(self.addressDictionary!, false)
            
            return postalAddressString.stringByTrimmingCharactersInSet(NSCharacterSet.newlineCharacterSet())
        Severity: Minor
        Found in iOS/SnapFresh/Model/FarmersMarket.swift and 1 other location - About 40 mins to fix
        iOS/SnapFresh/Model/SnapRetailer.swift on lines 65..70

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                else {
            let error = NSError(domain: "com.shrtlist.snapfresh", code: 99, userInfo: [NSLocalizedFailureReasonErrorKey:"Invalid coordinate"])
            NSNotificationCenter.defaultCenter().postNotificationName(Constants.kSNAPRetailersDidNotLoadNotification, object: error)
        }
        Severity: Minor
        Found in iOS/SnapFresh/Controllers/RequestController.swift and 1 other location - About 35 mins to fix
        iOS/SnapFresh/Controllers/RequestController.swift on lines 179..182

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            func postInvalidCoordinateErrorNotification() {
        let error = NSError(domain: "com.shrtlist.snapfresh", code:99, userInfo: [NSLocalizedFailureReasonErrorKey:"Invalid coordinate"])
        NSNotificationCenter.defaultCenter().postNotificationName(Constants.kFarmersMarketsDidNotLoadNotification, object: error)
    }
        Severity: Minor
        Found in iOS/SnapFresh/Controllers/RequestController.swift and 1 other location - About 35 mins to fix
        iOS/SnapFresh/Controllers/RequestController.swift on lines 61..64

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function sendSNAPRequestForCoordinate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            func sendSNAPRequestForCoordinate(coordinate: CLLocationCoordinate2D) {
        if CLLocationCoordinate2DIsValid(coordinate) {
            let coordinateString = NSString(format: "%f,%f", coordinate.latitude, coordinate.longitude)
            let urlString = NSString(format: "%@%@?address=%@", Constants.kSnapFreshBaseURL, Constants.kSnapFreshEndpoint, coordinateString)
            let url = NSURL(string: urlString as String)
        Severity: Minor
        Found in iOS/SnapFresh/Controllers/RequestController.swift - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language