Sign upLogin

ytti/oxidized

View on GitHub
Star
lib/oxidized/hook/exec.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method validate_cfg! has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

  def validate_cfg!
    # Syntax check
    if cfg.has_key? "timeout"
      @timeout = cfg.timeout
      raise "invalid timeout value" unless @timeout.is_a?(Integer) &&
Severity: Minor
Found in lib/oxidized/hook/exec.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run_hook has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def run_hook(ctx)
    env = make_env ctx
    log "Execute: #{@cmd.inspect}", :debug
    th = Thread.new do
      run_cmd! env
Severity: Minor
Found in lib/oxidized/hook/exec.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status