Sign upLogin

yupe/yupe

View on GitHub
Star
protected/modules/category/controllers/CategoryBackendController.php

Summary

Maintainability
D
1 day
Test Coverage

Method actionCreate has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function actionCreate()
    {
        $model = new Category();

        if (($data = Yii::app()->getRequest()->getPost('Category')) !== null) {
Severity: Major
Found in protected/modules/category/controllers/CategoryBackendController.php - About 2 hrs to fix

    Method actionUpdate has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function actionUpdate($id)
    {
        // Указан ID новости страницы, редактируем только ее
        $model = $this->loadModel($id);
    Severity: Minor
    Found in protected/modules/category/controllers/CategoryBackendController.php - About 1 hr to fix

      Function actionCreate has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function actionCreate()
    {
        $model = new Category();

        if (($data = Yii::app()->getRequest()->getPost('Category')) !== null) {
      Severity: Minor
      Found in protected/modules/category/controllers/CategoryBackendController.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function actionDelete has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function actionDelete($id)
    {
        if (Yii::app()->getRequest()->getIsPostRequest()) {

            $transaction = Yii::app()->db->beginTransaction();
      Severity: Minor
      Found in protected/modules/category/controllers/CategoryBackendController.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 13 locations. Consider refactoring.
      Open

          public function accessRules()
    {
        return [
            ['allow', 'roles' => ['admin']],
            ['allow', 'actions' => ['index'], 'roles' => ['Category.CategoryBackend.Index']],
      Severity: Major
      Found in protected/modules/category/controllers/CategoryBackendController.php and 12 other locations - About 4 hrs to fix
      protected/modules/blog/controllers/BlogBackendController.php on lines 18..29
      protected/modules/blog/controllers/UserToBlogBackendController.php on lines 18..29
      protected/modules/contentblock/controllers/ContentBlockBackendController.php on lines 18..33
      protected/modules/coupon/controllers/CouponBackendController.php on lines 18..29
      protected/modules/dictionary/controllers/DictionaryBackendController.php on lines 15..26
      protected/modules/dictionary/controllers/DictionaryDataBackendController.php on lines 15..26
      protected/modules/mail/controllers/EventBackendController.php on lines 17..28
      protected/modules/mail/controllers/TemplateBackendController.php on lines 14..25
      protected/modules/menu/controllers/MenuBackendController.php on lines 18..29
      protected/modules/news/controllers/NewsBackendController.php on lines 18..29
      protected/modules/page/controllers/PageBackendController.php on lines 23..34
      protected/modules/queue/controllers/QueueBackendController.php on lines 19..30

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 162.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function actionDelete($id)
    {
        if (Yii::app()->getRequest()->getIsPostRequest()) {

            $transaction = Yii::app()->db->beginTransaction();
      Severity: Major
      Found in protected/modules/category/controllers/CategoryBackendController.php and 1 other location - About 3 hrs to fix
      protected/modules/store/controllers/CategoryBackendController.php on lines 141..171

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 158.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if (($data = Yii::app()->getRequest()->getPost('Category')) !== null) {
            $model->setAttributes(Yii::app()->getRequest()->getPost('Category'));

            if ($model->save()) {
      Severity: Major
      Found in protected/modules/category/controllers/CategoryBackendController.php and 1 other location - About 2 hrs to fix
      protected/modules/store/controllers/CategoryBackendController.php on lines 101..121

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 128.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status