Sign upLogin

yupe/yupe

View on GitHub
Star
protected/modules/install/controllers/DefaultController.php

Summary

Maintainability
F
1 wk
Test Coverage

File DefaultController.php has 943 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Default Install Controller
 *
 * @category YupeControllers
Severity: Major
Found in protected/modules/install/controllers/DefaultController.php - About 2 days to fix

    Method actionRequirements has 174 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function actionRequirements()
    {
        $requirements = [
            [
                Yii::t('InstallModule.install', 'РНР version'),
    Severity: Major
    Found in protected/modules/install/controllers/DefaultController.php - About 6 hrs to fix

      Function actionModulesinstall has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
      Open

          public function actionModulesinstall()
    {
        set_time_limit(180);

        $error = false;
      Severity: Minor
      Found in protected/modules/install/controllers/DefaultController.php - About 6 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method actionDbsettings has 151 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function actionDbsettings()
    {
        $this->_markFinished('requirements');

        $dbConfFile = Yii::app()->basePath.'/config/'.'db.php';
      Severity: Major
      Found in protected/modules/install/controllers/DefaultController.php - About 6 hrs to fix

        Function actionDbsettings has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
        Open

            public function actionDbsettings()
    {
        $this->_markFinished('requirements');

        $dbConfFile = Yii::app()->basePath.'/config/'.'db.php';
        Severity: Minor
        Found in protected/modules/install/controllers/DefaultController.php - About 5 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function actionSitesettings has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
        Open

            public function actionSitesettings()
    {
        $model = new InstallForm('siteSettings');

        if (isset($this->session['InstallForm']['siteSettings'])) {
        Severity: Minor
        Found in protected/modules/install/controllers/DefaultController.php - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method actionEnvironment has 112 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function actionEnvironment()
    {

        $webRoot = Yii::getPathOfAlias('webroot');
        $app = Yii::getPathOfAlias('application');
        Severity: Major
        Found in protected/modules/install/controllers/DefaultController.php - About 4 hrs to fix

          Method actionSitesettings has 106 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function actionSitesettings()
    {
        $model = new InstallForm('siteSettings');

        if (isset($this->session['InstallForm']['siteSettings'])) {
          Severity: Major
          Found in protected/modules/install/controllers/DefaultController.php - About 4 hrs to fix

            Method actionModulesinstall has 96 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function actionModulesinstall()
    {
        set_time_limit(180);

        $error = false;
            Severity: Major
            Found in protected/modules/install/controllers/DefaultController.php - About 3 hrs to fix

              Method actionCreateuser has 74 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function actionCreateuser()
    {
        $model = new InstallForm('createUser');

        if (isset($this->session['InstallForm']['createUser'])) {
              Severity: Major
              Found in protected/modules/install/controllers/DefaultController.php - About 2 hrs to fix

                Function actionCreateuser has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function actionCreateuser()
    {
        $model = new InstallForm('createUser');

        if (isset($this->session['InstallForm']['createUser'])) {
                Severity: Minor
                Found in protected/modules/install/controllers/DefaultController.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method _checkServerVar has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    private function _checkServerVar()
    {
        $vars = [
            'HTTP_HOST',
            'SERVER_NAME',
                Severity: Minor
                Found in protected/modules/install/controllers/DefaultController.php - About 1 hr to fix

                  Function _checkCaptchaSupport has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                      private function _checkCaptchaSupport()
    {
        if (extension_loaded('imagick')) {
            $imagick = new Imagick();
            $imagickFormats = $imagick->queryFormats('PNG');
                  Severity: Minor
                  Found in protected/modules/install/controllers/DefaultController.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function _checkServerVar has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      private function _checkServerVar()
    {
        $vars = [
            'HTTP_HOST',
            'SERVER_NAME',
                  Severity: Minor
                  Found in protected/modules/install/controllers/DefaultController.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function actionRequirements has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function actionRequirements()
    {
        $requirements = [
            [
                Yii::t('InstallModule.install', 'РНР version'),
                  Severity: Minor
                  Found in protected/modules/install/controllers/DefaultController.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          if (isset($this->session['InstallForm']['createUser'])) {
            $model->setAttributes($this->session['InstallForm']['createUser']);
            if ($model->validate() && $this->session['InstallForm']['createUserStep'] === true) {
                $this->session['InstallForm'] = array_merge(
                    $this->session['InstallForm'],
                  Severity: Major
                  Found in protected/modules/install/controllers/DefaultController.php and 1 other location - About 2 hrs to fix
                  protected/modules/install/controllers/DefaultController.php on lines 1057..1071

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 138.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          if (isset($this->session['InstallForm']['siteSettings'])) {
            $model->setAttributes($this->session['InstallForm']['siteSettings']);
            if ($model->validate() && $this->session['InstallForm']['siteSettingsStep'] === true) {
                $this->session['InstallForm'] = array_merge(
                    $this->session['InstallForm'],
                  Severity: Major
                  Found in protected/modules/install/controllers/DefaultController.php and 1 other location - About 2 hrs to fix
                  protected/modules/install/controllers/DefaultController.php on lines 957..971

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 138.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status