Sign upLogin

yupe/yupe

View on GitHub
Star
protected/modules/tinkoffpay/components/payments/TinkoffPaymentSystem.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method processCheckout has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function processCheckout(Payment $payment, CHttpRequest $request)
    {

        $postData = json_decode($request->getRawBody(), JSON_UNESCAPED_UNICODE);
Severity: Minor
Found in protected/modules/tinkoffpay/components/payments/TinkoffPaymentSystem.php - About 1 hr to fix

    Method getPaymentPostData has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getPaymentPostData(Payment $payment, Order $order)
    {
        $settings = $payment->getPaymentSystemSettings();

        $receipt = [];
    Severity: Minor
    Found in protected/modules/tinkoffpay/components/payments/TinkoffPaymentSystem.php - About 1 hr to fix

      Function processCheckout has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public function processCheckout(Payment $payment, CHttpRequest $request)
    {

        $postData = json_decode($request->getRawBody(), JSON_UNESCAPED_UNICODE);
      Severity: Minor
      Found in protected/modules/tinkoffpay/components/payments/TinkoffPaymentSystem.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getPaymentPostData has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getPaymentPostData(Payment $payment, Order $order)
    {
        $settings = $payment->getPaymentSystemSettings();

        $receipt = [];
      Severity: Minor
      Found in protected/modules/tinkoffpay/components/payments/TinkoffPaymentSystem.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function processInit has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function processInit(CHttpRequest $request, Order $order)
    {
        if (!$order) {
            $message = Yii::t('TinkoffPayModule.tpay', 'The order doesn\'t exist.');
            Yii::log($message, CLogger::LEVEL_ERROR);
      Severity: Minor
      Found in protected/modules/tinkoffpay/components/payments/TinkoffPaymentSystem.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status