Sign upLogin

yupe/yupe

View on GitHub
Star
protected/modules/user/UserModule.php

Summary

Maintainability
F
3 days
Test Coverage

File UserModule.php has 369 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * UserModule основной класс модуля user
 *
Severity: Minor
Found in protected/modules/user/UserModule.php - About 4 hrs to fix

    Method getAuthItems has 59 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getAuthItems()
    {
        return [
            [
                'name' => 'User.UserManager',
    Severity: Major
    Found in protected/modules/user/UserModule.php - About 2 hrs to fix

      UserModule has 22 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class UserModule extends WebModule
{
    /**
     *
     */
      Severity: Minor
      Found in protected/modules/user/UserModule.php - About 2 hrs to fix

        Method getEditableParamsGroups has 50 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getEditableParamsGroups()
    {
        return [
            'security' => [
                'label' => Yii::t('UserModule.user', 'Security settings'),
        Severity: Minor
        Found in protected/modules/user/UserModule.php - About 2 hrs to fix

          Method checkSelf has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function checkSelf()
    {
        $messages = [];

        if (!$this->avatarsDir) {
          Severity: Minor
          Found in protected/modules/user/UserModule.php - About 1 hr to fix

            Method getParamsLabels has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function getParamsLabels()
    {
        return [
            'accountActivationSuccess' => Yii::t('UserModule.user', 'Page after account activation'),
            'accountActivationFailure' => Yii::t('UserModule.user', 'Page after activation error'),
            Severity: Minor
            Found in protected/modules/user/UserModule.php - About 1 hr to fix

              Method getEditableParams has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function getEditableParams()
    {
        return [
            'avatarMaxSize',
            'avatarExtensions',
              Severity: Minor
              Found in protected/modules/user/UserModule.php - About 1 hr to fix

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                    public function getAuthItems()
    {
        return [
            [
                'name' => 'User.UserManager',
                Severity: Major
                Found in protected/modules/user/UserModule.php and 3 other locations - About 1 day to fix
                protected/modules/mail/MailModule.php on lines 215..278
                protected/modules/menu/MenuModule.php on lines 158..221
                protected/modules/yupe/YupeModule.php on lines 863..924

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 366.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status