Sign upLogin

yupe/yupe

View on GitHub
Star
protected/modules/yupe/components/Migrator.php

Summary

Maintainability
D
2 days
Test Coverage

File Migrator.php has 414 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Migrator class file.
 *
 * @category YupeComponent
Severity: Minor
Found in protected/modules/yupe/components/Migrator.php - About 5 hrs to fix

    Method checkForBadMigration has 106 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function checkForBadMigration($module, $class = false)
    {
        echo Yii::t('YupeModule.yupe', "Checking for pending migrations").'<br />';

        $db = $this->getDbConnection();
    Severity: Major
    Found in protected/modules/yupe/components/Migrator.php - About 4 hrs to fix

      Function checkForBadMigration has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          public function checkForBadMigration($module, $class = false)
    {
        echo Yii::t('YupeModule.yupe', "Checking for pending migrations").'<br />';

        $db = $this->getDbConnection();
      Severity: Minor
      Found in protected/modules/yupe/components/Migrator.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getNewMigrations has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function getNewMigrations($module)
    {
        $applied = [];
        foreach ($this->getMigrationHistory($module, -1) as $version => $time) {
            if ($time) {
      Severity: Minor
      Found in protected/modules/yupe/components/Migrator.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method migrateUp has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function migrateUp($module, $class)
    {
        $db = $this->getDbConnection();

        ob_start();
      Severity: Major
      Found in protected/modules/yupe/components/Migrator.php - About 2 hrs to fix

        Method migrateDown has 49 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function migrateDown($module, $class)
    {
        Yii::log(Yii::t('YupeModule.yupe', "Downgrade migration {class}", ['{class}' => $class]));
        $db = $this->getDbConnection();
        $start = microtime(true);
        Severity: Minor
        Found in protected/modules/yupe/components/Migrator.php - About 1 hr to fix

          Function updateToLatest has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              public function updateToLatest($module)
    {
        if (($newMigrations = $this->getNewMigrations($module)) !== []) {

            if (Yii::app()->hasComponent('cache')) {
          Severity: Minor
          Found in protected/modules/yupe/components/Migrator.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method updateToLatest has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function updateToLatest($module)
    {
        if (($newMigrations = $this->getNewMigrations($module)) !== []) {

            if (Yii::app()->hasComponent('cache')) {
          Severity: Minor
          Found in protected/modules/yupe/components/Migrator.php - About 1 hr to fix

            Method getNewMigrations has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function getNewMigrations($module)
    {
        $applied = [];
        foreach ($this->getMigrationHistory($module, -1) as $version => $time) {
            if ($time) {
            Severity: Minor
            Found in protected/modules/yupe/components/Migrator.php - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if ($result !== false) {
            $db->createCommand()->delete(
                $db->tablePrefix.$this->migrationTable,
                [
                    'AND',
              Severity: Minor
              Found in protected/modules/yupe/components/Migrator.php and 1 other location - About 50 mins to fix
              protected/modules/yupe/components/Migrator.php on lines 262..296

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 97.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if ($result !== false) {
            // Проставляем "установлено"
            $db->createCommand()->update(
                $db->tablePrefix.$this->migrationTable,
                ['apply_time' => time()],
              Severity: Minor
              Found in protected/modules/yupe/components/Migrator.php and 1 other location - About 50 mins to fix
              protected/modules/yupe/components/Migrator.php on lines 320..360

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 97.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status