Sign upLogin

yupe/yupe

View on GitHub
Star
protected/modules/zendsearch/vendors/Zend/Search/Lucene/Search/Query/Phrase.php

Summary

Maintainability
D
2 days
Test Coverage

Function _sloppyPhraseFreq has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

    public function _sloppyPhraseFreq($docId, Zend_Search_Lucene_Interface $reader)
    {
        $freq = 0;

        $phraseQueue = [];
Severity: Minor
Found in protected/modules/zendsearch/vendors/Zend/Search/Lucene/Search/Query/Phrase.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Phrase.php has 307 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Zend Framework
 *
 * LICENSE
Severity: Minor
Found in protected/modules/zendsearch/vendors/Zend/Search/Lucene/Search/Query/Phrase.php - About 3 hrs to fix

    Function execute has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        public function execute(Zend_Search_Lucene_Interface $reader, $docsFilter = null)
    {
        $this->_resVector = null;

        if (count($this->_terms) == 0) {
    Severity: Minor
    Found in protected/modules/zendsearch/vendors/Zend/Search/Lucene/Search/Query/Phrase.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method _sloppyPhraseFreq has 51 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function _sloppyPhraseFreq($docId, Zend_Search_Lucene_Interface $reader)
    {
        $freq = 0;

        $phraseQueue = [];
    Severity: Major
    Found in protected/modules/zendsearch/vendors/Zend/Search/Lucene/Search/Query/Phrase.php - About 2 hrs to fix

      Function _exactPhraseFreq has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          public function _exactPhraseFreq($docId)
    {
        $freq = 0;

        // Term Id with lowest cardinality
      Severity: Minor
      Found in protected/modules/zendsearch/vendors/Zend/Search/Lucene/Search/Query/Phrase.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method execute has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function execute(Zend_Search_Lucene_Interface $reader, $docsFilter = null)
    {
        $this->_resVector = null;

        if (count($this->_terms) == 0) {
      Severity: Minor
      Found in protected/modules/zendsearch/vendors/Zend/Search/Lucene/Search/Query/Phrase.php - About 1 hr to fix

        Function __construct has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            public function __construct($terms = null, $offsets = null, $field = null)
    {
        $this->_slop = 0;

        if (is_array($terms)) {
        Severity: Minor
        Found in protected/modules/zendsearch/vendors/Zend/Search/Lucene/Search/Query/Phrase.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method __construct has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function __construct($terms = null, $offsets = null, $field = null)
    {
        $this->_slop = 0;

        if (is_array($terms)) {
        Severity: Minor
        Found in protected/modules/zendsearch/vendors/Zend/Search/Lucene/Search/Query/Phrase.php - About 1 hr to fix

          Function rewrite has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public function rewrite(Zend_Search_Lucene_Interface $index)
    {
        if (count($this->_terms) == 0) {
            require_once 'Zend/Search/Lucene/Search/Query/Empty.php';
          Severity: Minor
          Found in protected/modules/zendsearch/vendors/Zend/Search/Lucene/Search/Query/Phrase.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function __toString has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public function __toString()
    {
        // It's used only for query visualisation, so we don't care about characters escaping
        if (isset($this->_terms[0]) && $this->_terms[0]->field !== null) {
            $query = $this->_terms[0]->field . ':';
          Severity: Minor
          Found in protected/modules/zendsearch/vendors/Zend/Search/Lucene/Search/Query/Phrase.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function score has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public function score($docId, Zend_Search_Lucene_Interface $reader)
    {
        if (isset($this->_resVector[$docId])) {
            if ($this->_slop == 0) {
                $freq = $this->_exactPhraseFreq($docId);
          Severity: Minor
          Found in protected/modules/zendsearch/vendors/Zend/Search/Lucene/Search/Query/Phrase.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  foreach ($resVectors as $nextResVector) {
            if ($this->_resVector === null) {
                $this->_resVector = $nextResVector;
            } else {
                //$this->_resVector = array_intersect_key($this->_resVector, $nextResVector);
          Severity: Minor
          Found in protected/modules/zendsearch/vendors/Zend/Search/Lucene/Search/Query/Phrase.php and 1 other location - About 1 hr to fix
          protected/modules/zendsearch/vendors/Zend/Search/Lucene/Search/Query/Boolean.php on lines 507..529

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 100.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status