Sign upLogin

yupe/yupe

View on GitHub
Star
protected/modules/zendsearch/vendors/Zend/Search/Lucene/Search/Query/Preprocessing/Term.php

Summary

Maintainability
D
2 days
Test Coverage

Function rewrite has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
Open

    public function rewrite(Zend_Search_Lucene_Interface $index)
    {
        if ($this->_field === null) {
            require_once 'Zend/Search/Lucene/Search/Query/MultiTerm.php';
            $query = new Zend_Search_Lucene_Search_Query_MultiTerm();
Severity: Minor
Found in protected/modules/zendsearch/vendors/Zend/Search/Lucene/Search/Query/Preprocessing/Term.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method rewrite has 110 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function rewrite(Zend_Search_Lucene_Interface $index)
    {
        if ($this->_field === null) {
            require_once 'Zend/Search/Lucene/Search/Query/MultiTerm.php';
            $query = new Zend_Search_Lucene_Search_Query_MultiTerm();
Severity: Major
Found in protected/modules/zendsearch/vendors/Zend/Search/Lucene/Search/Query/Preprocessing/Term.php - About 4 hrs to fix

    Function _highlightMatches has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function _highlightMatches(Zend_Search_Lucene_Search_Highlighter_Interface $highlighter)
    {
        /** Skip fields detection. We don't need it, since we expect all fields presented in the HTML body and don't differentiate them */

        /** Skip exact term matching recognition, keyword fields highlighting is not supported */
    Severity: Minor
    Found in protected/modules/zendsearch/vendors/Zend/Search/Lucene/Search/Query/Preprocessing/Term.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method _highlightMatches has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function _highlightMatches(Zend_Search_Lucene_Search_Highlighter_Interface $highlighter)
    {
        /** Skip fields detection. We don't need it, since we expect all fields presented in the HTML body and don't differentiate them */

        /** Skip exact term matching recognition, keyword fields highlighting is not supported */
    Severity: Minor
    Found in protected/modules/zendsearch/vendors/Zend/Search/Lucene/Search/Query/Preprocessing/Term.php - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

                  return new Zend_Search_Lucene_Search_Query_Insignificant();
      Severity: Major
      Found in protected/modules/zendsearch/vendors/Zend/Search/Lucene/Search/Query/Preprocessing/Term.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return $rewrittenQuery;
        Severity: Major
        Found in protected/modules/zendsearch/vendors/Zend/Search/Lucene/Search/Query/Preprocessing/Term.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return $query;
          Severity: Major
          Found in protected/modules/zendsearch/vendors/Zend/Search/Lucene/Search/Query/Preprocessing/Term.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return $query;
            Severity: Major
            Found in protected/modules/zendsearch/vendors/Zend/Search/Lucene/Search/Query/Preprocessing/Term.php - About 30 mins to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (count($tokens) == 1) {
            require_once 'Zend/Search/Lucene/Index/Term.php';
            $term = new Zend_Search_Lucene_Index_Term($tokens[0]->getTermText(), $this->_field);
            require_once 'Zend/Search/Lucene/Search/Query/Term.php';
            $query = new Zend_Search_Lucene_Search_Query_Term($term);
              Severity: Minor
              Found in protected/modules/zendsearch/vendors/Zend/Search/Lucene/Search/Query/Preprocessing/Term.php and 1 other location - About 40 mins to fix
              protected/modules/zendsearch/vendors/Zend/Search/Lucene/Search/Query/Preprocessing/Phrase.php on lines 181..191

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 93.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status