Sign upLogin

yupe/yupe

View on GitHub
Star
protected/modules/zendsearch/vendors/Zend/Search/Lucene/Storage/File.php

Summary

Maintainability
F
3 days
Test Coverage

Function readString has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    public function readString()
    {
        $strlen = $this->readVInt();
        if ($strlen == 0) {
            return '';
Severity: Minor
Found in protected/modules/zendsearch/vendors/Zend/Search/Lucene/Storage/File.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Zend_Search_Lucene_Storage_File has 22 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class Zend_Search_Lucene_Storage_File
{
    /**
     * Reads $length number of bytes at the current position in the
     * file and advances the file pointer.
Severity: Minor
Found in protected/modules/zendsearch/vendors/Zend/Search/Lucene/Storage/File.php - About 2 hrs to fix

    Function writeString has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        public function writeString($str)
    {
        /**
         * This implementation supports only Basic Multilingual Plane
         * (BMP) characters (from 0x0000 to 0xFFFF) and doesn't support
    Severity: Minor
    Found in protected/modules/zendsearch/vendors/Zend/Search/Lucene/Storage/File.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method writeString has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function writeString($str)
    {
        /**
         * This implementation supports only Basic Multilingual Plane
         * (BMP) characters (from 0x0000 to 0xFFFF) and doesn't support
    Severity: Minor
    Found in protected/modules/zendsearch/vendors/Zend/Search/Lucene/Storage/File.php - About 1 hr to fix

      Method readString has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function readString()
    {
        $strlen = $this->readVInt();
        if ($strlen == 0) {
            return '';
      Severity: Minor
      Found in protected/modules/zendsearch/vendors/Zend/Search/Lucene/Storage/File.php - About 1 hr to fix

        Function readLong32Bit has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function readLong32Bit()
    {
        $wordHigh = $this->readInt();
        $wordLow = $this->readInt();
        Severity: Minor
        Found in protected/modules/zendsearch/vendors/Zend/Search/Lucene/Storage/File.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    return ord($str[0]) << 56 |
            ord($str[1]) << 48 |
            ord($str[2]) << 40 |
            ord($str[3]) << 32 |
            ord($str[4]) << 24 |
        Severity: Major
        Found in protected/modules/zendsearch/vendors/Zend/Search/Lucene/Storage/File.php and 1 other location - About 3 hrs to fix
        protected/modules/zendsearch/vendors/Zend/Search/Lucene/Storage/File/Memory.php on lines 295..302

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 147.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                        chr($value >> 56 & 0xFF) .
                chr($value >> 48 & 0xFF) .
                chr($value >> 40 & 0xFF) .
                chr($value >> 32 & 0xFF) .
                chr($value >> 24 & 0xFF) .
        Severity: Major
        Found in protected/modules/zendsearch/vendors/Zend/Search/Lucene/Storage/File.php and 1 other location - About 3 hrs to fix
        protected/modules/zendsearch/vendors/Zend/Search/Lucene/Storage/File/Memory.php on lines 325..332

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 145.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                for ($count = 0; $count < $strlen; $count++) {
            /**
             * String is already in Java 2 representation.
             * We should only calculate actual string length and replace
             * \x00 by \xC0\x80
        Severity: Major
        Found in protected/modules/zendsearch/vendors/Zend/Search/Lucene/Storage/File.php and 1 other location - About 3 hrs to fix
        protected/modules/zendsearch/vendors/Zend/Search/Lucene/Storage/File/Memory.php on lines 538..562

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 143.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            public function writeLong32Bit($value)
    {
        if ($value < (int)0x80000000) {
            require_once 'Zend/Search/Lucene/Exception.php';
            throw new Zend_Search_Lucene_Exception('Long integers lower than -2147483648 (0x80000000) are not supported on 32-bit platforms.');
        Severity: Major
        Found in protected/modules/zendsearch/vendors/Zend/Search/Lucene/Storage/File.php and 1 other location - About 2 hrs to fix
        protected/modules/zendsearch/vendors/Zend/Search/Lucene/Storage/File/Memory.php on lines 383..407

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 137.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            public function readLong32Bit()
    {
        $wordHigh = $this->readInt();
        $wordLow = $this->readInt();
        Severity: Major
        Found in protected/modules/zendsearch/vendors/Zend/Search/Lucene/Storage/File.php and 1 other location - About 2 hrs to fix
        protected/modules/zendsearch/vendors/Zend/Search/Lucene/Storage/File/Memory.php on lines 347..375

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 127.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                            if (ord($str_val[$count]) == 0xC0 &&
                        ord($str_val[$count + 1]) == 0x80
                    ) {
                        $str_val[$count] = 0;
                        $str_val = substr($str_val, 0, $count + 1)
        Severity: Major
        Found in protected/modules/zendsearch/vendors/Zend/Search/Lucene/Storage/File.php and 2 other locations - About 45 mins to fix
        protected/modules/zendsearch/vendors/Zend/Search/Lucene/Index/DictionaryLoader.php on lines 156..162
        protected/modules/zendsearch/vendors/Zend/Search/Lucene/Storage/File/Memory.php on lines 493..499

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 96.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status