Sign upLogin

yyewolf/bar

View on GitHub
Star
backend/api/passerCommande.go

Summary

Maintainability
F
3 days
Test Coverage

Method Server.PostTransactions has a Cognitive Complexity of 171 (exceeds 50 allowed). Consider refactoring.
Open

func (s *Server) PostTransactions(c echo.Context) error {
    // Get account from cookie
    account, err := MustGetUser(c)
    if err != nil {
        return nil
Severity: Minor
Found in backend/api/passerCommande.go - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Server.PostTransactions has 249 lines of code (exceeds 100 allowed). Consider refactoring.
Open

func (s *Server) PostTransactions(c echo.Context) error {
    // Get account from cookie
    account, err := MustGetUser(c)
    if err != nil {
        return nil
Severity: Major
Found in backend/api/passerCommande.go - About 6 hrs to fix

    Method Server.PostTransactions has 32 return statements (exceeds 20 allowed).
    Open

    func (s *Server) PostTransactions(c echo.Context) error {
    // Get account from cookie
    account, err := MustGetUser(c)
    if err != nil {
        return nil
    Severity: Major
    Found in backend/api/passerCommande.go - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  for _, menuItem := range *item.MenuItems {
                mItem, err := s.DBackend.GetItem(c.Request().Context(), menuItem.Id.String())
                if err != nil {
                    if err == mongo.ErrNoDocuments {
                        return nil, ErrorItemNotFound(c)
      Severity: Minor
      Found in backend/api/passerCommande.go and 1 other location - About 55 mins to fix
      backend/api/passerCommande.go on lines 101..111

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 127.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  for _, pickedItem := range *potentialItem.PickedCategoriesItems {
                mItem, err := s.DBackend.GetItem(c.Request().Context(), pickedItem.ItemId.String())
                if err != nil {
                    if err == mongo.ErrNoDocuments {
                        return nil, ErrorItemNotFound(c)
      Severity: Minor
      Found in backend/api/passerCommande.go and 1 other location - About 55 mins to fix
      backend/api/passerCommande.go on lines 86..96

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 127.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status