Sign upLogin

yyewolf/bar

View on GitHub
Star
backend/api/validerCommande.go

Summary

Maintainability
F
4 days
Test Coverage

Method Server.PatchTransactionItemId has a Cognitive Complexity of 148 (exceeds 50 allowed). Consider refactoring.
Open

func (s *Server) PatchTransactionItemId(c echo.Context, accountId autogen.UUID, transactionId autogen.UUID, itemId autogen.UUID, params autogen.PatchTransactionItemIdParams) error {
    _, err := MustGetAdmin(c)
    if err != nil {
        return nil
    }
Severity: Minor
Found in backend/api/validerCommande.go - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Server.PatchTransactionId has a Cognitive Complexity of 92 (exceeds 50 allowed). Consider refactoring.
Open

func (s *Server) PatchTransactionId(c echo.Context, accountId autogen.UUID, transactionId autogen.UUID, params autogen.PatchTransactionIdParams) error {
    _, err := MustGetAdmin(c)
    if err != nil {
        return nil
    }
Severity: Minor
Found in backend/api/validerCommande.go - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Server.PatchTransactionItemId has 165 lines of code (exceeds 100 allowed). Consider refactoring.
Open

func (s *Server) PatchTransactionItemId(c echo.Context, accountId autogen.UUID, transactionId autogen.UUID, itemId autogen.UUID, params autogen.PatchTransactionItemIdParams) error {
    _, err := MustGetAdmin(c)
    if err != nil {
        return nil
    }
Severity: Major
Found in backend/api/validerCommande.go - About 3 hrs to fix

    Method Server.PatchTransactionId has 107 lines of code (exceeds 100 allowed). Consider refactoring.
    Open

    func (s *Server) PatchTransactionId(c echo.Context, accountId autogen.UUID, transactionId autogen.UUID, params autogen.PatchTransactionIdParams) error {
    _, err := MustGetAdmin(c)
    if err != nil {
        return nil
    }
    Severity: Major
    Found in backend/api/validerCommande.go - About 1 hr to fix

      Method Server.PatchTransactionItemId has 24 return statements (exceeds 20 allowed).
      Open

      func (s *Server) PatchTransactionItemId(c echo.Context, accountId autogen.UUID, transactionId autogen.UUID, itemId autogen.UUID, params autogen.PatchTransactionItemIdParams) error {
    _, err := MustGetAdmin(c)
    if err != nil {
        return nil
    }
      Severity: Major
      Found in backend/api/validerCommande.go - About 50 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                    if err == mongo.ErrNoDocuments {
                                continue
                            }
        Severity: Major
        Found in backend/api/validerCommande.go - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                      if err == mongo.ErrNoDocuments {
                                continue
                            }
          Severity: Major
          Found in backend/api/validerCommande.go - About 45 mins to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                            if item.PickedCategoriesItems != nil {
                    for _, pickedItem := range *item.PickedCategoriesItems {
                        pItem, err := s.DBackend.GetItem(ctx, pickedItem.ItemId.String())
                        if err != nil {
                            continue
            Severity: Major
            Found in backend/api/validerCommande.go and 2 other locations - About 1 hr to fix
            backend/api/validerCommande.go on lines 70..83
            backend/api/validerCommande.go on lines 85..98

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 134.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                                if txitem.PickedCategoriesItems != nil {
                        for _, pickedItem := range *txitem.PickedCategoriesItems {
                            pItem, err := s.DBackend.GetItem(ctx, pickedItem.ItemId.String())
                            if err != nil {
                                continue
            Severity: Major
            Found in backend/api/validerCommande.go and 2 other locations - About 1 hr to fix
            backend/api/validerCommande.go on lines 70..83
            backend/api/validerCommande.go on lines 291..304

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 134.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                                if item.MenuItems != nil {
                        for _, subitem := range *txitem.MenuItems {
                            sItem, err := s.DBackend.GetItem(ctx, subitem.Id.String())
                            if err != nil {
                                continue
            Severity: Major
            Found in backend/api/validerCommande.go and 2 other locations - About 1 hr to fix
            backend/api/validerCommande.go on lines 85..98
            backend/api/validerCommande.go on lines 291..304

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 134.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status