Sign upLogin

zHd4/NoteSR

View on GitHub
Star

Showing 37 of 37 total issues

Method cryptoKeyToHex has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public static String cryptoKeyToHex(CryptoKey cryptoKey) {
        byte[] keyBytes = cryptoKey.getKey().getEncoded();
        byte[] salt = cryptoKey.getSalt();
        byte[] bytes = new byte[keyBytes.length + salt.length];
 
 
Severity: Minor
Found in app/src/main/java/app/notesr/crypto/CryptoTools.java - About 35 mins to fix

Method onCreateOptionsMenu has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public boolean onCreateOptionsMenu(Menu menu) {
        EditText nameField = findViewById(R.id.noteNameField);
        EditText textField = findViewById(R.id.noteTextField);
 
 
Severity: Minor
Found in app/src/main/java/app/notesr/activity/notes/OpenNoteActivity.java - About 35 mins to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public String getFileName() {
        try (Cursor cursor = getCursor(uri)) {
            int index = cursor.getColumnIndex(OpenableColumns.DISPLAY_NAME);
 
            cursor.moveToFirst();
Severity: Minor
Found in app/src/main/java/app/notesr/util/FileExifDataResolver.java and 1 other location - About 35 mins to fix
app/src/main/java/app/notesr/util/FileExifDataResolver.java on lines 26..33

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public long getFileSize() {
        try (Cursor cursor = getCursor(uri)) {
            int index = cursor.getColumnIndex(OpenableColumns.SIZE);
 
            cursor.moveToFirst();
Severity: Minor
Found in app/src/main/java/app/notesr/util/FileExifDataResolver.java and 1 other location - About 35 mins to fix
app/src/main/java/app/notesr/util/FileExifDataResolver.java on lines 17..24

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private Note setDecimalId(Note note) {
        UUID uuid = UUID.fromString(note.getId());
        long hash = HashHelper.getUUIDHash(uuid);
 
        note.setDecimalId(hash);
Severity: Minor
Found in app/src/main/java/app/notesr/service/NoteService.java and 1 other location - About 30 mins to fix
app/src/main/java/app/notesr/service/FileService.java on lines 155..162

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if (view == null) {
            LayoutInflater inflater;
            inflater = LayoutInflater.from(context);
            view = inflater.inflate(resourceLayout, null);
        }
Severity: Minor
Found in app/src/main/java/app/notesr/adapter/FileListAdapter.java and 1 other location - About 30 mins to fix
app/src/main/java/app/notesr/adapter/NoteListAdapter.java on lines 28..32

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if (view == null) {
            LayoutInflater inflater;
            inflater = LayoutInflater.from(context);
            view = inflater.inflate(resourceLayout, null);
        }
Severity: Minor
Found in app/src/main/java/app/notesr/adapter/NoteListAdapter.java and 1 other location - About 30 mins to fix
app/src/main/java/app/notesr/adapter/FileListAdapter.java on lines 52..56

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private FileInfo setDecimalId(FileInfo fileInfo) {
        UUID uuid = UUID.fromString(fileInfo.getId());
        long hash = HashHelper.getUUIDHash(uuid);
 
        fileInfo.setDecimalId(hash);
Severity: Minor
Found in app/src/main/java/app/notesr/service/FileService.java and 1 other location - About 30 mins to fix
app/src/main/java/app/notesr/service/NoteService.java on lines 73..80

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private void returnToListActivity() {
        Intent intent = new Intent(App.getContext(), FileListActivity.class)
                .putExtra("noteId", fileInfo.getNoteId())
                .putExtra("modified", true)
                .addFlags(Intent.FLAG_ACTIVITY_CLEAR_TOP);
Severity: Minor
Found in app/src/main/java/app/notesr/activity/files/viewer/FileViewerActivityBase.java and 1 other location - About 30 mins to fix
app/src/main/java/app/notesr/activity/files/FileListActivity.java on lines 73..80

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if (noteModified) {
                Intent intent = new Intent(App.getContext(), OpenNoteActivity.class)
                        .putExtra("noteId", note.getId())
                        .putExtra("modified", true)
                        .addFlags(Intent.FLAG_ACTIVITY_CLEAR_TOP);
Severity: Minor
Found in app/src/main/java/app/notesr/activity/files/FileListActivity.java and 1 other location - About 30 mins to fix
app/src/main/java/app/notesr/activity/files/viewer/FileViewerActivityBase.java on lines 101..108

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private static final Map<String, Bitmap.CompressFormat> COMPRESS_FORMAT_MAP = Map.of(
            "jpg", Bitmap.CompressFormat.JPEG,
            "jpeg", Bitmap.CompressFormat.JPEG,
            "png", Bitmap.CompressFormat.PNG,
            "webp", Bitmap.CompressFormat.WEBP
Severity: Minor
Found in app/src/main/java/app/notesr/util/thumbnail/ImageThumbnailCreator.java and 1 other location - About 30 mins to fix
app/src/main/java/app/notesr/adapter/FileListAdapter.java on lines 24..29

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private static final Map<String, Integer> FILES_TYPES_ICONS = Map.of(
            "text", R.drawable.text_file,
            "image", R.drawable.image_file,
            "video", R.drawable.video_file,
            "audio", R.drawable.audio_file
Severity: Minor
Found in app/src/main/java/app/notesr/adapter/FileListAdapter.java and 1 other location - About 30 mins to fix
app/src/main/java/app/notesr/util/thumbnail/ImageThumbnailCreator.java on lines 20..25

Method onOptionsItemSelected has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public boolean onOptionsItemSelected(MenuItem item) {
        int id = item.getItemId();
 
        if (id == android.R.id.home) {
Severity: Minor
Found in app/src/main/java/app/notesr/activity/notes/OpenNoteActivity.java - About 25 mins to fix

Method selectFileCallback has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    private ActivityResultCallback<ActivityResult> selectFileCallback() {
        return result -> {
            int resultCode = result.getResultCode();
 
            if (resultCode == Activity.RESULT_OK) {
Severity: Minor
Found in app/src/main/java/app/notesr/activity/data/ImportActivity.java - About 25 mins to fix

Method dataReceiver has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    private BroadcastReceiver dataReceiver() {
        return new BroadcastReceiver() {
            @Override
            public void onReceive(Context context, Intent intent) {
                String status = intent.getStringExtra("status");
Severity: Minor
Found in app/src/main/java/app/notesr/activity/data/ImportActivity.java - About 25 mins to fix

Method wipeFileData has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    private static void wipeFileData(File file) throws IOException {
        long fileSize = file.length();
 
        try (FileOutputStream stream = new FileOutputStream(file)) {
            try {
Severity: Minor
Found in app/src/main/java/app/notesr/util/Wiper.java - About 25 mins to fix

Method start has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public void start() {
        Thread thread = new Thread(() -> {
            try {
                tempDir = new File(context.getCacheDir(), randomUUID().toString());
Severity: Minor
Found in app/src/main/java/app/notesr/service/data/importer/v2/ImportServiceV2.java - About 25 mins to fix
Severity
Category
Status
Source
Language