Sign upLogin

zacstewart/tengai

View on GitHub
Star

Showing 25 of 25 total issues

Similar blocks of code found in 4 locations. Consider refactoring.
Open

self._body_data_sheet_parser_range_lengths = [
    0, 0, 0, 0, 0, 0, 0, 0, 
    0, 1, 1, 1, 0, 1, 1, 0, 
    0, 1, 1, 1, 1, 0, 4, 4, 
    5, 1, 1, 2, 1, 5, 5, 5,
Severity: Major
Found in ext/horizons/body_data_sheet_parser.rb and 3 other locations - About 1 hr to fix
ext/horizons/body_data_sheet_parser.rb on lines 178..185
ext/horizons/body_data_sheet_parser.rb on lines 232..239
ext/horizons/body_data_sheet_parser.rb on lines 258..265

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid deeply nested control flow statements.
Open

            case _ephemeris_parser_actions[_acts - 1]
when 0 then
# line 6 "ext/horizons/vector_ephemeris_parser.rl"
        begin
 mark = p         end
Severity: Major
Found in ext/horizons/vector_ephemeris_parser.rb - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                case _body_data_sheet_parser_actions[_acts - 1]
when 0 then
# line 5 "ext/horizons/body_data_sheet_parser.rl"
        begin
 mark = p         end
    Severity: Major
    Found in ext/horizons/body_data_sheet_parser.rb - About 45 mins to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          if _goto_level <= _again
    if cs == 0
        _goto_level = _out
        next
    end
      Severity: Minor
      Found in ext/horizons/body_data_sheet_parser.rb and 1 other location - About 15 mins to fix
      ext/horizons/vector_ephemeris_parser.rb on lines 161..170

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          if _goto_level <= _again
    if cs == 0
        _goto_level = _out
        next
    end
      Severity: Minor
      Found in ext/horizons/vector_ephemeris_parser.rb and 1 other location - About 15 mins to fix
      ext/horizons/body_data_sheet_parser.rb on lines 137..146

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language