Sign upLogin

zammad/zammad

View on GitHub
Star
app/controllers/application_controller/authenticates.rb

Summary

Maintainability
B
7 hrs
Test Coverage

Method authentication_check_only has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

  def authentication_check_only
    if %w[test development].include?(Rails.env) && ENV['FAKE_SELENIUM_LOGIN_USER_ID'].present? && session[:user_id].blank?
      session[:user_id] = ENV['FAKE_SELENIUM_LOGIN_USER_ID'].to_i
      session[:user_device_updated_at] = Time.zone.now
      session[:authentication_type] = 'password'
Severity: Minor
Found in app/controllers/application_controller/authenticates.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method authentication_check_only has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def authentication_check_only
    if %w[test development].include?(Rails.env) && ENV['FAKE_SELENIUM_LOGIN_USER_ID'].present? && session[:user_id].blank?
      session[:user_id] = ENV['FAKE_SELENIUM_LOGIN_USER_ID'].to_i
      session[:user_device_updated_at] = Time.zone.now
      session[:authentication_type] = 'password'
Severity: Major
Found in app/controllers/application_controller/authenticates.rb - About 2 hrs to fix

    Avoid too many return statements within this method.
    Open

        return false if authentication_errors.blank?
    Severity: Major
    Found in app/controllers/application_controller/authenticates.rb - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status