Sign upLogin

zammad/zammad

View on GitHub
Star
app/controllers/long_polling_controller.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method message_send has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def message_send
    new_connection = false

    # check client id
    client_id = client_id_verify
Severity: Minor
Found in app/controllers/long_polling_controller.rb - About 1 hr to fix

    Method message_receive has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def message_receive

    # check client id
    client_id = client_id_verify
    raise Exceptions::UnprocessableEntity, __('Invalid client_id received!') if !client_id
    Severity: Minor
    Found in app/controllers/long_polling_controller.rb - About 1 hr to fix

      Method message_receive has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def message_receive

    # check client id
    client_id = client_id_verify
    raise Exceptions::UnprocessableEntity, __('Invalid client_id received!') if !client_id
      Severity: Minor
      Found in app/controllers/long_polling_controller.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method message_send has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def message_send
    new_connection = false

    # check client id
    client_id = client_id_verify
      Severity: Minor
      Found in app/controllers/long_polling_controller.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status