Sign upLogin

zammad/zammad

View on GitHub
Star
app/controllers/reports_controller.rb

Summary

Maintainability
C
1 day
Test Coverage

Method params_all has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def params_all
    profile = nil
    if !params[:profiles] && !params[:profile_id]
      raise Exceptions::UnprocessableEntity, __("Required parameter 'profile' is missing.")
    end
Severity: Major
Found in app/controllers/reports_controller.rb - About 2 hrs to fix

    Method sets has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

      def sets
    get_params = params_all
    return if !get_params

    if !params[:downloadBackendSelected]
    Severity: Minor
    Found in app/controllers/reports_controller.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method sets has 53 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def sets
    get_params = params_all
    return if !get_params

    if !params[:downloadBackendSelected]
    Severity: Major
    Found in app/controllers/reports_controller.rb - About 2 hrs to fix

      Method params_all has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

        def params_all
    profile = nil
    if !params[:profiles] && !params[:profile_id]
      raise Exceptions::UnprocessableEntity, __("Required parameter 'profile' is missing.")
    end
      Severity: Minor
      Found in app/controllers/reports_controller.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method generate has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        def generate
    get_params = params_all
    return if !get_params

    result = {}
      Severity: Minor
      Found in app/controllers/reports_controller.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method generate has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def generate
    get_params = params_all
    return if !get_params

    result = {}
      Severity: Minor
      Found in app/controllers/reports_controller.rb - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status