Sign upLogin

zammad/zammad

View on GitHub
Star
app/controllers/time_accountings_controller.rb

Summary

Maintainability
F
3 days
Test Coverage

Method by_activity has 103 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def by_activity
    year  = params[:year] || Time.zone.now.year
    month = params[:month] || Time.zone.now.month

    start_period = Time.zone.parse("#{year}-#{month}-01")
Severity: Major
Found in app/controllers/time_accountings_controller.rb - About 4 hrs to fix

    File time_accountings_controller.rb has 334 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class TimeAccountingsController < ApplicationController
  prepend_before_action :authenticate_and_authorize!

  def index
    model_index_render(ticket_time_accounting_scope, params)
    Severity: Minor
    Found in app/controllers/time_accountings_controller.rb - About 4 hrs to fix

      Method by_activity has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
      Open

        def by_activity
    year  = params[:year] || Time.zone.now.year
    month = params[:month] || Time.zone.now.month

    start_period = Time.zone.parse("#{year}-#{month}-01")
      Severity: Minor
      Found in app/controllers/time_accountings_controller.rb - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method by_customer has 69 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def by_customer
    year  = params[:year] || Time.zone.now.year
    month = params[:month] || Time.zone.now.month

    start_period = Time.zone.parse("#{year}-#{month}-01")
      Severity: Major
      Found in app/controllers/time_accountings_controller.rb - About 2 hrs to fix

        Method by_ticket has 64 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def by_ticket
    year  = params[:year] || Time.zone.now.year
    month = params[:month] || Time.zone.now.month

    start_period = Time.zone.parse("#{year}-#{month}-01")
        Severity: Major
        Found in app/controllers/time_accountings_controller.rb - About 2 hrs to fix

          Method by_organization has 61 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def by_organization
    year  = params[:year] || Time.zone.now.year
    month = params[:month] || Time.zone.now.month

    start_period = Time.zone.parse("#{year}-#{month}-01")
          Severity: Major
          Found in app/controllers/time_accountings_controller.rb - About 2 hrs to fix

            Method by_organization has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
            Open

              def by_organization
    year  = params[:year] || Time.zone.now.year
    month = params[:month] || Time.zone.now.month

    start_period = Time.zone.parse("#{year}-#{month}-01")
            Severity: Minor
            Found in app/controllers/time_accountings_controller.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method by_ticket has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

              def by_ticket
    year  = params[:year] || Time.zone.now.year
    month = params[:month] || Time.zone.now.month

    start_period = Time.zone.parse("#{year}-#{month}-01")
            Severity: Minor
            Found in app/controllers/time_accountings_controller.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method by_customer has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

              def by_customer
    year  = params[:year] || Time.zone.now.year
    month = params[:month] || Time.zone.now.month

    start_period = Time.zone.parse("#{year}-#{month}-01")
            Severity: Minor
            Found in app/controllers/time_accountings_controller.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                results = Ticket::TimeAccounting
      .where(created_at: (start_period..end_period))
      .pluck(:ticket_id, :time_unit, :created_by_id)
      .each_with_object({}) do |record, memo|
        memo[record[0]] ||= {
            Severity: Minor
            Found in app/controllers/time_accountings_controller.rb and 1 other location - About 50 mins to fix
            app/controllers/time_accountings_controller.rb on lines 225..235

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 43.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                results = Ticket::TimeAccounting
      .where(created_at: (start_period..end_period))
      .pluck(:ticket_id, :time_unit, :created_by_id)
      .each_with_object({}) do |record, memo|
        memo[record[0]] ||= {
            Severity: Minor
            Found in app/controllers/time_accountings_controller.rb and 1 other location - About 50 mins to fix
            app/controllers/time_accountings_controller.rb on lines 303..313

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 43.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status