Sign upLogin

zammad/zammad

View on GitHub
Star
app/controllers/users_controller.rb

Summary

Maintainability
F
3 days
Test Coverage

File users_controller.rb has 679 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class UsersController < ApplicationController
  include ChecksUserAttributesByCurrentUserPermission
  include CanPaginate

  prepend_before_action -> { authorize! }, only: %i[import_example import_start search history unlock]
Severity: Major
Found in app/controllers/users_controller.rb - About 1 day to fix

    Class UsersController has 35 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class UsersController < ApplicationController
  include ChecksUserAttributesByCurrentUserPermission
  include CanPaginate

  prepend_before_action -> { authorize! }, only: %i[import_example import_start search history unlock]
    Severity: Minor
    Found in app/controllers/users_controller.rb - About 4 hrs to fix

      Method search has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

        def search
    query = params[:query]
    if query.respond_to?(:permit!)
      query.permit!.to_h
    end
      Severity: Minor
      Found in app/controllers/users_controller.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method search has 58 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def search
    query = params[:query]
    if query.respond_to?(:permit!)
      query.permit!.to_h
    end
      Severity: Major
      Found in app/controllers/users_controller.rb - About 2 hrs to fix

        Method create_internal has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def create_internal
    # permission check
    check_attributes_by_current_user_permission(params)

    user = User.new(clean_user_params)
        Severity: Minor
        Found in app/controllers/users_controller.rb - About 1 hr to fix

          Method update has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def update
    user = User.find(params[:id])
    authorize!(user)

    # permission check
          Severity: Minor
          Found in app/controllers/users_controller.rb - About 1 hr to fix

            Method password_reset_verify has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def password_reset_verify
    raise Exceptions::UnprocessableEntity, 'token param needed!' if params[:token].blank?

    # If no password is given, verify token only.
    if params[:password].blank?
            Severity: Minor
            Found in app/controllers/users_controller.rb - About 1 hr to fix

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                def import_start
    string = params[:data]
    if string.blank? && params[:file].present?
      string = params[:file].read.force_encoding('utf-8')
    end
              Severity: Major
              Found in app/controllers/users_controller.rb and 2 other locations - About 1 hr to fix
              app/controllers/organizations_controller.rb on lines 276..292
              app/controllers/text_modules_controller.rb on lines 181..197

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 57.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                    assets = {}
      item_ids = []
      users.each do |item|
        item_ids.push item.id
        assets = item.assets(assets)
              Severity: Minor
              Found in app/controllers/users_controller.rb and 2 other locations - About 25 mins to fix
              app/controllers/activity_stream_controller.rb on lines 17..28
              app/controllers/recent_view_controller.rb on lines 31..42

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 31.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    user_ids = []
      assets   = {}
      user_all.each do |user|
        assets = user.assets(assets)
        user_ids.push user.id
              Severity: Minor
              Found in app/controllers/users_controller.rb and 1 other location - About 25 mins to fix
              app/controllers/organizations_controller.rb on lines 222..235

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 30.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status