Sign upLogin

zammad/zammad

View on GitHub
Star
app/frontend/apps/desktop/entities/channel-email/composables/useEmailChannelConfiguration.ts

Summary

Maintainability
F
3 days
Test Coverage

Function useEmailChannelConfiguration has 282 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const useEmailChannelConfiguration = (
  emailChannelForms: EmailChannelForms,
  metaInformationInbound: Ref<Maybe<EmailInboundMetaInformation>>,
  updateMetaInformationInbound: UpdateMetaInformationInboundFunction,
  onSuccessCallback: () => void,
Severity: Major
Found in app/frontend/apps/desktop/entities/channel-email/composables/useEmailChannelConfiguration.ts - About 1 day to fix

    Function useEmailChannelConfiguration has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
    Open

    export const useEmailChannelConfiguration = (
  emailChannelForms: EmailChannelForms,
  metaInformationInbound: Ref<Maybe<EmailInboundMetaInformation>>,
  updateMetaInformationInbound: UpdateMetaInformationInboundFunction,
  onSuccessCallback: () => void,
    Severity: Minor
    Found in app/frontend/apps/desktop/entities/channel-email/composables/useEmailChannelConfiguration.ts - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File useEmailChannelConfiguration.ts has 319 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    // Copyright (C) 2012-2024 Zammad Foundation, https://zammad-foundation.org/

import type { SetNonNullable, SetOptional } from 'type-fest'
import type { Ref } from 'vue'
import { computed, ref, watch } from 'vue'
    Severity: Minor
    Found in app/frontend/apps/desktop/entities/channel-email/composables/useEmailChannelConfiguration.ts - About 3 hrs to fix

      Function validateConfigurationRoundtripAndChannelAdd has 72 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        const validateConfigurationRoundtripAndChannelAdd = async (
    account: EmailAccountData,
    inboundConfiguration: EmailInboundData,
    outboundConfiguration: EmailOutboundData,
  ) => {
      Severity: Major
      Found in app/frontend/apps/desktop/entities/channel-email/composables/useEmailChannelConfiguration.ts - About 2 hrs to fix

        Function guessEmailAccount has 69 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          const guessEmailAccount = (data: FormSubmitData<EmailAccountData>) => {
    loading.value = true

    const guessConfigurationMutation = new MutationHandler(
      useChannelEmailGuessConfigurationMutation(),
        Severity: Major
        Found in app/frontend/apps/desktop/entities/channel-email/composables/useEmailChannelConfiguration.ts - About 2 hrs to fix

          Function validateEmailInbound has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            const validateEmailInbound = (data: FormSubmitData<EmailInboundData>) => {
    loading.value = true

    const validationConfigurationInbound = new MutationHandler(
      useChannelEmailValidateConfigurationInboundMutation(),
          Severity: Minor
          Found in app/frontend/apps/desktop/entities/channel-email/composables/useEmailChannelConfiguration.ts - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  await validateConfigurationRoundtripAndChannelAdd(
        emailChannelForms.emailAccount.values.value,
        emailChannelForms.emailInbound.values.value,
        emailChannelForms.emailOutbound.values.value,
      )
            Severity: Minor
            Found in app/frontend/apps/desktop/entities/channel-email/composables/useEmailChannelConfiguration.ts and 1 other location - About 35 mins to fix
            app/frontend/apps/desktop/entities/channel-email/composables/useEmailChannelConfiguration.ts on lines 342..346

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                      await validateConfigurationRoundtripAndChannelAdd(
            emailChannelForms.emailAccount.values.value,
            emailChannelForms.emailInbound.values.value,
            emailChannelForms.emailOutbound.values.value,
          )
            Severity: Minor
            Found in app/frontend/apps/desktop/entities/channel-email/composables/useEmailChannelConfiguration.ts and 1 other location - About 35 mins to fix
            app/frontend/apps/desktop/entities/channel-email/composables/useEmailChannelConfiguration.ts on lines 314..318

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                      const outboundConfiguration = result.channelEmailGuessConfiguration
            .result.outboundConfiguration as SetOptional<
            SetNonNullable<Required<ChannelEmailOutboundConfiguration>>,
            '__typename'
          >
            Severity: Minor
            Found in app/frontend/apps/desktop/entities/channel-email/composables/useEmailChannelConfiguration.ts and 1 other location - About 35 mins to fix
            app/frontend/apps/desktop/entities/channel-email/composables/useEmailChannelConfiguration.ts on lines 192..196

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                      const inboundConfiguration = result.channelEmailGuessConfiguration
            .result.inboundConfiguration as SetOptional<
            SetNonNullable<Required<ChannelEmailInboundConfiguration>>,
            '__typename'
          >
            Severity: Minor
            Found in app/frontend/apps/desktop/entities/channel-email/composables/useEmailChannelConfiguration.ts and 1 other location - About 35 mins to fix
            app/frontend/apps/desktop/entities/channel-email/composables/useEmailChannelConfiguration.ts on lines 199..203

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status