zammad/zammad

View on GitHub
app/frontend/apps/mobile/pages/ticket/composable/useTicketsMerge.ts

Summary

Maintainability
C
1 day
Test Coverage

Function useTicketsMerge has 89 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const useTicketsMerge = (
  sourceTicket: Ref<TicketById>,
  onSuccess?: () => void,
) => {
  const autocompleteRef = ref<{ node: FormKitNode }>()
Severity: Major
Found in app/frontend/apps/mobile/pages/ticket/composable/useTicketsMerge.ts - About 3 hrs to fix

    Function useTicketsMerge has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

    export const useTicketsMerge = (
      sourceTicket: Ref<TicketById>,
      onSuccess?: () => void,
    ) => {
      const autocompleteRef = ref<{ node: FormKitNode }>()
    Severity: Minor
    Found in app/frontend/apps/mobile/pages/ticket/composable/useTicketsMerge.ts - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function mergeTickets has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      const mergeTickets = async () => {
        const context = autocompleteRef.value?.node.context
        if (!context || mergeHandler.loading().value) return false
    
        const targetTicketId = context._value
    Severity: Minor
    Found in app/frontend/apps/mobile/pages/ticket/composable/useTicketsMerge.ts - About 1 hr to fix

      Avoid too many return statements within this function.
      Open

          return false
      Severity: Major
      Found in app/frontend/apps/mobile/pages/ticket/composable/useTicketsMerge.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return true
        Severity: Major
        Found in app/frontend/apps/mobile/pages/ticket/composable/useTicketsMerge.ts - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status