zammad/zammad

View on GitHub
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts

Summary

Maintainability
D
1 day
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  test("doesn't remove extra break lines", () => {
    const source = `<p>This is a note<br><br></p><blockquote type="cite">
<p>On .+, #{article.created_by.fullname} wrote:</p>\n<p><br></p>
<p>#{article.body}</p>\n
</blockquote><p><br></p>`
Severity: Major
Found in app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts and 1 other location - About 1 hr to fix
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 144..180

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it('clears lists and new lines', () => {
    const source = `<div>Wir führen eine (Produktiv-) Freshdesk Migratione für hosted Kunden kostenfrei durch.</div><div><br></div><div>
<h3>Ablauf der Migration:</h3>
<div><ul>
<li>Abstimmung zum Projektablauf und Zeitplan</li>
Severity: Major
Found in app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts and 1 other location - About 1 hr to fix
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 182..191

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 14 locations. Consider refactoring.
Open

  it('removes wrapper for "br"', () => {
    const source = '<div><br></div>'
    const should = '<p></p>'
    const result = htmlCleanup(source)
    assert.equal(result, should, source)
Severity: Major
Found in app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts and 13 other locations - About 50 mins to fix
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 9..14
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 16..21
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 23..28
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 50..55
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 57..62
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 71..76
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 78..83
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 85..90
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 92..98
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 100..106
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 117..124
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 126..133
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 135..142

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 14 locations. Consider refactoring.
Open

  it('removes subform', () => {
    const source = '<form class="xxx">test 123</form> some other value'
    const should = 'test 123 some other value'
    const result = htmlCleanup(source)
    assert.equal(result, should, source)
Severity: Major
Found in app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts and 13 other locations - About 50 mins to fix
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 9..14
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 16..21
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 23..28
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 50..55
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 57..62
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 64..69
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 71..76
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 78..83
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 92..98
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 100..106
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 117..124
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 126..133
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 135..142

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 14 locations. Consider refactoring.
Open

  it('clears external tags', () => {
    const source =
      '<div><div><label for="Ticket_888344_group_id">Gruppe <span>*</span></label></div><div><div></div></div><div><div><span></span><span></span></div></div><div><div><label for="Ticket_888344_owner_id">Besitzer <span></span></label></div><div><div></div></div></div><div><div><div><svg><use xlink:href="http://localhost:3000/assets/images/icons.svg#icon-arrow-down"></use></svg></div><span></span><span></span></div></div><div><div>    <label for="Ticket_888344_state_id">Status <span>*</span></label></div></div></div>\n'
    const should =
      '<div><div>Gruppe <span>*</span></div><div><div></div></div><div><div><span></span><span></span></div></div><div><div>Besitzer <span></span></div><div><div></div></div></div><div><div><div></div><span></span><span></span></div></div><div><div>    Status <span>*</span></div></div></div>'
Severity: Major
Found in app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts and 13 other locations - About 50 mins to fix
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 9..14
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 16..21
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 23..28
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 50..55
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 57..62
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 64..69
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 71..76
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 78..83
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 85..90
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 92..98
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 100..106
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 126..133
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 135..142

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 14 locations. Consider refactoring.
Open

  it('keeps text as is', () => {
    const source = 'some link to somewhere'
    const should = 'some link to somewhere'
    const result = htmlCleanup(source)
    assert.equal(result, should, source)
Severity: Major
Found in app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts and 13 other locations - About 50 mins to fix
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 9..14
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 23..28
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 50..55
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 57..62
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 64..69
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 71..76
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 78..83
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 85..90
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 92..98
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 100..106
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 117..124
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 126..133
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 135..142

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 14 locations. Consider refactoring.
Open

  it('removes wrapper for several children', () => {
    const source = '<h1>some h1 for somewhere</h1><p><hr></p>'
    const should = '<h1>some h1 for somewhere</h1><p></p><hr><p></p>'
    const result = htmlCleanup(source)
    assert.equal(result, should, source)
Severity: Major
Found in app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts and 13 other locations - About 50 mins to fix
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 9..14
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 16..21
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 23..28
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 50..55
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 64..69
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 71..76
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 78..83
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 85..90
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 92..98
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 100..106
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 117..124
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 126..133
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 135..142

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 14 locations. Consider refactoring.
Open

  it('removes comments', () => {
    const source = '<div><!--test comment--><a href="test">test</a></div>'
    const should = '<div><a href="test">test</a></div>'
    const result = htmlCleanup(source)
    assert.equal(result, should, source)
Severity: Major
Found in app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts and 13 other locations - About 50 mins to fix
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 16..21
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 23..28
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 50..55
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 57..62
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 64..69
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 71..76
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 78..83
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 85..90
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 92..98
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 100..106
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 117..124
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 126..133
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 135..142

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 14 locations. Consider refactoring.
Open

  it('removes form', () => {
    const source = '<form class="xxx">test 123</form>'
    const should = 'test 123'
    const result = htmlCleanup(source)
    assert.equal(result, should, source)
Severity: Major
Found in app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts and 13 other locations - About 50 mins to fix
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 9..14
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 16..21
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 23..28
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 50..55
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 57..62
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 64..69
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 71..76
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 85..90
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 92..98
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 100..106
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 117..124
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 126..133
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 135..142

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 14 locations. Consider refactoring.
Open

  it('clears html head', () => {
    const source =
      '<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">\n<html>\n<head>\n  <meta http-equiv="content-type" content="text/html; charset=utf-8"/>\n  <title></title>\n  <meta name="generator" content="LibreOffice 4.4.7.2 (MacOSX)"/>\n  <style type="text/css">\n    @page { margin: 0.79in }\n    p { margin-bottom: 0.1in; line-height: 120% }\n    a:link { so-language: zxx }\n  </style>\n</head>\n<body lang="en-US" dir="ltr">\n<p align="center" style="margin-bottom: 0in; line-height: 100%">1.\nGehe a<b>uf </b><b>https://www.pfe</b>rdiathek.ge</p>\n<p align="center" style="margin-bottom: 0in; line-height: 100%"><br/>\n\n</p>\n<p align="center" style="margin-bottom: 0in; line-height: 100%">2.\nMel<font color="#800000">de Dich mit folgende</font> Zugangsdaten an:</p>\n<p align="center" style="margin-bottom: 0in; line-height: 100%">Benutzer:\nme@xxx.net</p>\n<p align="center" style="margin-bottom: 0in; line-height: 100%">Passwort:\nxxx.</p>\n</body>\n</html>'
    const should =
      '<p align="center" style="margin-bottom: 0in; line-height: 100%">1.\nGehe a<b>uf </b><b>https://www.pfe</b>rdiathek.ge</p><p align="center" style="margin-bottom: 0in; line-height: 100%"></p><p align="center" style="margin-bottom: 0in; line-height: 100%">2.\nMel<font color="#800000">de Dich mit folgende</font> Zugangsdaten an:</p><p align="center" style="margin-bottom: 0in; line-height: 100%">Benutzer:\nme@xxx.net</p><p align="center" style="margin-bottom: 0in; line-height: 100%">Passwort:\nxxx.</p>\n'
Severity: Major
Found in app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts and 13 other locations - About 50 mins to fix
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 9..14
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 16..21
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 23..28
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 50..55
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 57..62
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 64..69
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 71..76
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 78..83
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 85..90
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 92..98
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 100..106
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 117..124
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 135..142

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 14 locations. Consider refactoring.
Open

  it('removes "time" tag', () => {
    const source = '<div><time>some link to somewhere</time></a>'
    const should = '<div>some link to somewhere</div>'
    const result = htmlCleanup(source)
    assert.equal(result, should, source)
Severity: Major
Found in app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts and 13 other locations - About 50 mins to fix
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 9..14
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 16..21
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 23..28
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 57..62
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 64..69
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 71..76
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 78..83
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 85..90
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 92..98
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 100..106
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 117..124
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 126..133
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 135..142

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 14 locations. Consider refactoring.
Open

  it('keeps inner div', () => {
    const source = '<div class="xxx"><br></div>'
    const should = '<p class="xxx"></p>'
    const result = htmlCleanup(source)
    assert.equal(result, should, source)
Severity: Major
Found in app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts and 13 other locations - About 50 mins to fix
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 9..14
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 16..21
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 23..28
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 50..55
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 57..62
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 64..69
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 78..83
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 85..90
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 92..98
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 100..106
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 117..124
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 126..133
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 135..142

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 14 locations. Consider refactoring.
Open

  it('removes svg', () => {
    const source =
      '<font size="3" color="red">This is some text!</font><svg><use xlink:href="assets/images/icons.svg#icon-status"></svg>'
    const should = '<font size="3" color="red">This is some text!</font>'
    const result = htmlCleanup(source)
Severity: Major
Found in app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts and 13 other locations - About 50 mins to fix
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 9..14
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 16..21
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 23..28
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 50..55
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 57..62
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 64..69
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 71..76
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 78..83
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 85..90
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 92..98
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 117..124
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 126..133
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 135..142

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 14 locations. Consider refactoring.
Open

  it('keeps lists as is', () => {
    const source = '<li>a</li><li>b</li>'
    const should = '<li>a</li><li>b</li>'
    const result = htmlCleanup(source)
    assert.equal(result, should, source)
Severity: Major
Found in app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts and 13 other locations - About 50 mins to fix
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 9..14
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 16..21
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 50..55
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 57..62
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 64..69
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 71..76
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 78..83
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 85..90
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 92..98
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 100..106
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 117..124
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 126..133
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 135..142

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 14 locations. Consider refactoring.
Open

  it('removes form tag and input', () => {
    const source =
      '<form class="xxx">test 123</form> some other value<input value="should not be shown">'
    const should = 'test 123 some other value'
    const result = htmlCleanup(source)
Severity: Major
Found in app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts and 13 other locations - About 50 mins to fix
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 9..14
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 16..21
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 23..28
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 50..55
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 57..62
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 64..69
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 71..76
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 78..83
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 85..90
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 100..106
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 117..124
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 126..133
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 135..142

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 14 locations. Consider refactoring.
Open

  it('clears table', () => {
    const source =
      '<table bgcolor="green" aaa="1"><thead><tr><th colspan="2" abc="a">aaa</th></tr></thead><tbody><tr><td>value</td></tr></tbody></table>'
    const should =
      '<table bgcolor="green" aaa="1"><thead><tr><th colspan="2" abc="a">aaa</th></tr></thead><tbody><tr><td>value</td></tr></tbody></table>'
Severity: Major
Found in app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts and 13 other locations - About 50 mins to fix
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 9..14
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 16..21
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 23..28
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 50..55
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 57..62
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 64..69
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 71..76
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 78..83
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 85..90
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 92..98
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 100..106
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 117..124
app/frontend/shared/utils/__tests__/htmlCleanup.spec.ts on lines 126..133

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status