app/frontend/shared/utils/htmlCleanup.ts
Function removeTrailingLineBreaks
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
Open
const removeTrailingLineBreaks = (parent: Element) => {
parent.querySelectorAll('br').forEach((element) => {
// keep paragraphs with just a line break, but convert them into <p> tags
if (element.parentElement?.childNodes.length === 1) {
if (element.parentElement.tagName !== 'DIV') {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Consider simplifying this complex logical expression. Open
Open
if (
// if <br> is the last element, remove it because editor will add one anyway
!nextSibling ||
// if next element is a block element, remove <br>, because it will be converted into a paragraph with a line break
(nextSibling.nodeType !== Node.TEXT_NODE &&