Sign upLogin

zammad/zammad

View on GitHub
Star
app/models/application_model/can_associations.rb

Summary

Maintainability
F
6 days
Test Coverage

Method association_name_to_id_convert has a Cognitive Complexity of 92 (exceeds 5 allowed). Consider refactoring.
Open

    def association_name_to_id_convert(params)

      if params.respond_to?(:permit!)
        params = params.permit!.to_h
      end
Severity: Minor
Found in app/models/application_model/can_associations.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method associations_from_param has a Cognitive Complexity of 64 (exceeds 5 allowed). Consider refactoring.
Open

  def associations_from_param(params)

    # special handling for group access association
    {
      groups:    :group_names_access_map=,
Severity: Minor
Found in app/models/application_model/can_associations.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method attributes_with_association_names has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
Open

  def attributes_with_association_names(empty_keys: false)

    # get relations
    attributes = attributes_with_association_ids
    self.class.reflect_on_all_associations.map do |assoc|
Severity: Minor
Found in app/models/application_model/can_associations.rb - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File can_associations.rb has 321 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module ApplicationModel::CanAssociations
  extend ActiveSupport::Concern

=begin
Severity: Minor
Found in app/models/application_model/can_associations.rb - About 3 hrs to fix

    Method association_name_to_id_convert has 73 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def association_name_to_id_convert(params)

      if params.respond_to?(:permit!)
        params = params.permit!.to_h
      end
    Severity: Major
    Found in app/models/application_model/can_associations.rb - About 2 hrs to fix

      Method associations_from_param has 69 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def associations_from_param(params)

    # special handling for group access association
    {
      groups:    :group_names_access_map=,
      Severity: Major
      Found in app/models/application_model/can_associations.rb - About 2 hrs to fix

        Method association_id_validation has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
        Open

          def association_id_validation(attribute_id, value)
    return true if value.nil?

    attributes.each_key do |key|
      next if key != attribute_id
        Severity: Minor
        Found in app/models/application_model/can_associations.rb - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method attributes_with_association_names has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def attributes_with_association_names(empty_keys: false)

    # get relations
    attributes = attributes_with_association_ids
    self.class.reflect_on_all_associations.map do |assoc|
        Severity: Minor
        Found in app/models/application_model/can_associations.rb - About 1 hr to fix

          Method attributes_with_association_ids has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

            def attributes_with_association_ids
    key = "#{self.class}::aws::#{id}"
    cache = Rails.cache.read(key)
    return filter_unauthorized_attributes(cache) if cache && cache['updated_at'] == try(:updated_at)
          Severity: Minor
          Found in app/models/application_model/can_associations.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method attributes_with_association_ids has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def attributes_with_association_ids
    key = "#{self.class}::aws::#{id}"
    cache = Rails.cache.read(key)
    return filter_unauthorized_attributes(cache) if cache && cache['updated_at'] == try(:updated_at)
          Severity: Minor
          Found in app/models/application_model/can_associations.rb - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                      if class_object == User
            if !value.instance_of?(String)
              raise Exceptions::UnprocessableEntity, "String is needed as ref value #{value.inspect} for '#{assoc_name}'"
            end
            Severity: Minor
            Found in app/models/application_model/can_associations.rb and 1 other location - About 55 mins to fix
            app/models/application_model/can_associations.rb on lines 428..440

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                      if class_object == User
            if !item.instance_of?(String)
              raise Exceptions::UnprocessableEntity, "String is needed in array ref as ref value #{value.inspect} for '#{assoc_name}'"
            end
            Severity: Minor
            Found in app/models/application_model/can_associations.rb and 1 other location - About 55 mins to fix
            app/models/application_model/can_associations.rb on lines 381..393

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status