Sign upLogin

zammad/zammad

View on GitHub
Star
app/models/avatar.rb

Summary

Maintainability
D
3 days
Test Coverage

Method add has a Cognitive Complexity of 58 (exceeds 5 allowed). Consider refactoring.
Open

  def self.add(data)
    # lookups
    if data[:object]
      object_id = ObjectLookup.by_name(data[:object])
    end
Severity: Minor
Found in app/models/avatar.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method add has 141 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.add(data)
    # lookups
    if data[:object]
      object_id = ObjectLookup.by_name(data[:object])
    end
Severity: Major
Found in app/models/avatar.rb - About 5 hrs to fix

    File avatar.rb has 334 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class Avatar < ApplicationModel
  include HasDefaultModelUserRelations
  include Avatar::TriggersSubscriptions

  belongs_to :object_lookup, optional: true
    Severity: Minor
    Found in app/models/avatar.rb - About 4 hrs to fix

      Avoid deeply nested control flow statements.
      Open

              return if !image
      Severity: Major
      Found in app/models/avatar.rb - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                return if avatar_already_exists&.source_url == url && avatar_already_exists.updated_at > 2.minutes.ago
        Severity: Major
        Found in app/models/avatar.rb - About 45 mins to fix

          Avoid too many return statements within this method.
          Open

                  return if !image
          Severity: Major
          Found in app/models/avatar.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return if avatar_already_exists&.source_url == url && avatar_already_exists.updated_at > 2.minutes.ago
            Severity: Major
            Found in app/models/avatar.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return avatar_already_exists
              Severity: Major
              Found in app/models/avatar.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                    return if record[:store_resize_id].blank? || record[:store_hash].blank?
                Severity: Major
                Found in app/models/avatar.rb - About 30 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      if data[:full].present?
      store_full = Store.create!(
        object:        "#{object_name}::Full",
        o_id:          data[:o_id],
        data:          data[:full][:content],
                  Severity: Major
                  Found in app/models/avatar.rb and 1 other location - About 1 hr to fix
                  app/models/avatar.rb on lines 232..244

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 55.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      if data[:resize].present?
      store_resize = Store.create!(
        object:        "#{object_name}::Resize",
        o_id:          data[:o_id],
        data:          data[:resize][:content],
                  Severity: Major
                  Found in app/models/avatar.rb and 1 other location - About 1 hr to fix
                  app/models/avatar.rb on lines 218..230

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 55.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status