Sign upLogin

zammad/zammad

View on GitHub
Star
app/models/cti/driver/placetel.rb

Summary

Maintainability
C
1 day
Test Coverage

Method load_voip_users has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def load_voip_users
    return {} if @config.blank? || @config[:api_token].blank?

    list = Rails.cache.read('placetelGetVoipUsers')
    return list if list
Severity: Minor
Found in app/models/cti/driver/placetel.rb - About 1 hr to fix

    Method load_voip_users has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

      def load_voip_users
    return {} if @config.blank? || @config[:api_token].blank?

    list = Rails.cache.read('placetelGetVoipUsers')
    return list if list
    Severity: Minor
    Found in app/models/cti/driver/placetel.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method mapping has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def mapping(params)

    # do event mapping
    case params['event']
    when 'IncomingCall'
    Severity: Minor
    Found in app/models/cti/driver/placetel.rb - About 1 hr to fix

      Method mapping has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

        def mapping(params)

    # do event mapping
    case params['event']
    when 'IncomingCall'
      Severity: Minor
      Found in app/models/cti/driver/placetel.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method push_open_ticket_screen_recipient has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def push_open_ticket_screen_recipient

    # try to find answering which answered call
    user = nil
      Severity: Minor
      Found in app/models/cti/driver/placetel.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method get_user_id_by_peer has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def get_user_id_by_peer(peer)
    return if @config.blank? || @config[:user_device_map].blank?

    @config[:user_device_map].each do |row|
      next if row[:user_id].blank?
      Severity: Minor
      Found in app/models/cti/driver/placetel.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

            return {}
      Severity: Major
      Found in app/models/cti/driver/placetel.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

              return {}
        Severity: Major
        Found in app/models/cti/driver/placetel.rb - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            def get_user_id_by_peer(peer)
    return if @config.blank? || @config[:user_device_map].blank?

    @config[:user_device_map].each do |row|
      next if row[:user_id].blank?
          Severity: Minor
          Found in app/models/cti/driver/placetel.rb and 1 other location - About 35 mins to fix
          app/models/cti/driver/sipgate_io.rb on lines 100..108

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 35.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            def push_open_ticket_screen_recipient

    # try to find answering which answered call
    user = nil
          Severity: Minor
          Found in app/models/cti/driver/placetel.rb and 1 other location - About 30 mins to fix
          app/models/cti/driver/sipgate_io.rb on lines 9..26

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status