zammad/zammad

View on GitHub
app/models/report.rb

Summary

Maintainability
D
2 days
Test Coverage

Method config has 303 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.config
    config = {}
    config[:metric] = {}

    config[:metric][:count] = {
Severity: Major
Found in app/models/report.rb - About 1 day to fix

    File report.rb has 310 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class Report
    
      def self.enabled?
        Setting.get('es_url').present?
      end
    Severity: Minor
    Found in app/models/report.rb - About 3 hrs to fix

      Similar blocks of code found in 7 locations. Consider refactoring.
      Open

            {
              name:         'phone_in',
              display:      __('Phone (in)'),
              selected:     true,
              dataDownload: true,
      Severity: Major
      Found in app/models/report.rb and 6 other locations - About 55 mins to fix
      app/models/report.rb on lines 102..120
      app/models/report.rb on lines 122..140
      app/models/report.rb on lines 142..160
      app/models/report.rb on lines 162..180
      app/models/report.rb on lines 182..200
      app/models/report.rb on lines 202..220

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 7 locations. Consider refactoring.
      Open

            {
              name:         'phone_out',
              display:      __('Phone (out)'),
              selected:     true,
              dataDownload: true,
      Severity: Major
      Found in app/models/report.rb and 6 other locations - About 55 mins to fix
      app/models/report.rb on lines 82..100
      app/models/report.rb on lines 122..140
      app/models/report.rb on lines 142..160
      app/models/report.rb on lines 162..180
      app/models/report.rb on lines 182..200
      app/models/report.rb on lines 202..220

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 7 locations. Consider refactoring.
      Open

            {
              name:         'web_in',
              display:      __('Web (in)'),
              selected:     true,
              dataDownload: true,
      Severity: Major
      Found in app/models/report.rb and 6 other locations - About 55 mins to fix
      app/models/report.rb on lines 82..100
      app/models/report.rb on lines 102..120
      app/models/report.rb on lines 122..140
      app/models/report.rb on lines 142..160
      app/models/report.rb on lines 182..200
      app/models/report.rb on lines 202..220

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 7 locations. Consider refactoring.
      Open

            {
              name:         'twitter_in',
              display:      __('Twitter (in)'),
              selected:     true,
              dataDownload: true,
      Severity: Major
      Found in app/models/report.rb and 6 other locations - About 55 mins to fix
      app/models/report.rb on lines 82..100
      app/models/report.rb on lines 102..120
      app/models/report.rb on lines 122..140
      app/models/report.rb on lines 142..160
      app/models/report.rb on lines 162..180
      app/models/report.rb on lines 202..220

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 7 locations. Consider refactoring.
      Open

            {
              name:         'twitter_out',
              display:      __('Twitter (out)'),
              selected:     true,
              dataDownload: true,
      Severity: Major
      Found in app/models/report.rb and 6 other locations - About 55 mins to fix
      app/models/report.rb on lines 82..100
      app/models/report.rb on lines 102..120
      app/models/report.rb on lines 122..140
      app/models/report.rb on lines 142..160
      app/models/report.rb on lines 162..180
      app/models/report.rb on lines 182..200

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 7 locations. Consider refactoring.
      Open

            {
              name:         'email_in',
              display:      __('Email (in)'),
              selected:     true,
              dataDownload: true,
      Severity: Major
      Found in app/models/report.rb and 6 other locations - About 55 mins to fix
      app/models/report.rb on lines 82..100
      app/models/report.rb on lines 102..120
      app/models/report.rb on lines 142..160
      app/models/report.rb on lines 162..180
      app/models/report.rb on lines 182..200
      app/models/report.rb on lines 202..220

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 7 locations. Consider refactoring.
      Open

            {
              name:         'email_out',
              display:      __('Email (out)'),
              selected:     true,
              dataDownload: true,
      Severity: Major
      Found in app/models/report.rb and 6 other locations - About 55 mins to fix
      app/models/report.rb on lines 82..100
      app/models/report.rb on lines 102..120
      app/models/report.rb on lines 122..140
      app/models/report.rb on lines 162..180
      app/models/report.rb on lines 182..200
      app/models/report.rb on lines 202..220

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status