Sign upLogin

zammad/zammad

View on GitHub
Star
app/models/transaction/notification.rb

Summary

Maintainability
D
2 days
Test Coverage

Method perform has a Cognitive Complexity of 76 (exceeds 5 allowed). Consider refactoring.
Open

  def perform

    # return if we run import mode
    return if Setting.get('import_mode')
    return if @item[:object] != 'Ticket'
Severity: Minor
Found in app/models/transaction/notification.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method perform has 153 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def perform

    # return if we run import mode
    return if Setting.get('import_mode')
    return if @item[:object] != 'Ticket'
Severity: Major
Found in app/models/transaction/notification.rb - About 6 hrs to fix

    Avoid too many return statements within this method.
    Open

            return if @item[:changes].blank? && article.preferences[:notification] != true
    Severity: Major
    Found in app/models/transaction/notification.rb - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status