zammad/zammad

View on GitHub
app/models/transaction/slack.rb

Summary

Maintainability
D
2 days
Test Coverage

Method perform has a Cognitive Complexity of 71 (exceeds 5 allowed). Consider refactoring.
Open

  def perform

    # return if we run import mode
    return if Setting.get('import_mode')

Severity: Minor
Found in app/models/transaction/slack.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method perform has 128 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def perform

    # return if we run import mode
    return if Setting.get('import_mode')

Severity: Major
Found in app/models/transaction/slack.rb - About 5 hrs to fix

    Avoid too many return statements within this method.
    Open

            return if @item[:changes].blank?
    Severity: Major
    Found in app/models/transaction/slack.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

          return if @item[:type] == 'update' && !article && changes.blank?
      Severity: Major
      Found in app/models/transaction/slack.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

            return if !config['items']
        Severity: Major
        Found in app/models/transaction/slack.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

              return if !ticket
          Severity: Major
          Found in app/models/transaction/slack.rb - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status