Sign upLogin

zammad/zammad

View on GitHub
Star
lib/email_helper.rb

Summary

Maintainability
F
3 days
Test Coverage

File email_helper.rb has 615 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class EmailHelper

=begin

get available driver
Severity: Major
Found in lib/email_helper.rb - About 1 day to fix

    Method provider_outbound_guess has 122 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def self.provider_outbound_guess(user, email, password, domain)
    [
      {
        adapter: 'smtp',
        options: {
    Severity: Major
    Found in lib/email_helper.rb - About 4 hrs to fix

      Method provider_inbound_guess has 102 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def self.provider_inbound_guess(user, email, password, domain)
    [
      {
        adapter: 'imap',
        options: {
      Severity: Major
      Found in lib/email_helper.rb - About 4 hrs to fix

        Method provider has 71 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def self.provider(email, password)
    # check domain based attributes
    {
      google_imap: {
        domain:   'gmail|googlemail|google',
        Severity: Major
        Found in lib/email_helper.rb - About 2 hrs to fix

          Method provider_outbound_mx has 65 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def self.provider_outbound_mx(user, email, password, mx_domains)
    outbounds = []
    mx_domains.each do |domain|
      outbound = [
        {
          Severity: Major
          Found in lib/email_helper.rb - About 2 hrs to fix

            Method provider_inbound_mx has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def self.provider_inbound_mx(user, email, password, mx_domains)
    inbounds = []
    mx_domains.each do |domain|
      inbound = [
        {
            Severity: Minor
            Found in lib/email_helper.rb - About 1 hr to fix

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                    google_imap: {
        domain:   'gmail|googlemail|google',
        inbound:  {
          adapter: 'imap',
          options: {
              Severity: Minor
              Found in lib/email_helper.rb and 2 other locations - About 35 mins to fix
              lib/email_helper.rb on lines 135..156
              lib/email_helper.rb on lines 158..179

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 35.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                    microsoft:   {
        domain:   'outlook.com|hotmail.com',
        inbound:  {
          adapter: 'imap',
          options: {
              Severity: Minor
              Found in lib/email_helper.rb and 2 other locations - About 35 mins to fix
              lib/email_helper.rb on lines 112..133
              lib/email_helper.rb on lines 158..179

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 35.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                    google_pop3: {
        domain:   'gmail|googlemail|google',
        inbound:  {
          adapter: 'pop3',
          options: {
              Severity: Minor
              Found in lib/email_helper.rb and 2 other locations - About 35 mins to fix
              lib/email_helper.rb on lines 112..133
              lib/email_helper.rb on lines 135..156

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 35.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status