Sign upLogin

zammad/zammad

View on GitHub
Star
lib/notification_factory/mailer.rb

Summary

Maintainability
D
2 days
Test Coverage

Method notification_settings has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
Open

  def self.notification_settings(user, ticket, type)

    # map types if needed
    map = {
      'escalation_warning' => 'escalation'
Severity: Minor
Found in lib/notification_factory/mailer.rb - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method notification_settings has 85 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.notification_settings(user, ticket, type)

    # map types if needed
    map = {
      'escalation_warning' => 'escalation'
Severity: Major
Found in lib/notification_factory/mailer.rb - About 3 hrs to fix

    File mailer.rb has 282 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class NotificationFactory::Mailer

=begin

get notification settings for user and notification type
    Severity: Minor
    Found in lib/notification_factory/mailer.rb - About 2 hrs to fix

      Method template has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def self.template(data)

    if data[:templateInline]
      return NotificationFactory::Renderer.new(
        objects:  data[:objects],
      Severity: Minor
      Found in lib/notification_factory/mailer.rb - About 2 hrs to fix

        Method already_sent? has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

          def self.already_sent?(ticket, recipient, type)
    result = ticket.history_get
    count  = 0
    result.each do |item|
      next if item['type'] != 'notification'
        Severity: Minor
        Found in lib/notification_factory/mailer.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

            return if !data['criteria']
        Severity: Major
        Found in lib/notification_factory/mailer.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

              return if !data
          Severity: Major
          Found in lib/notification_factory/mailer.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                return if !matrix[type]
            Severity: Major
            Found in lib/notification_factory/mailer.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                  return if !channels
              Severity: Major
              Found in lib/notification_factory/mailer.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                      return {
        user:     user,
        channels: channels
      }
                Severity: Major
                Found in lib/notification_factory/mailer.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                        return {
        user:     user,
        channels: channels
      }
                  Severity: Major
                  Found in lib/notification_factory/mailer.rb - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                        return if !data['criteria']['no']
                    Severity: Major
                    Found in lib/notification_factory/mailer.rb - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                            return {
        user:     user,
        channels: channels
      }
                      Severity: Major
                      Found in lib/notification_factory/mailer.rb - About 30 mins to fix

                        There are no issues that match your filters.

                        Category
                        Status