Sign upLogin

zammad/zammad

View on GitHub
Star
lib/sessions/backend/base.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def initialize(user, asset_lookup, client, client_id, ttl = 10)
Severity: Minor
Found in lib/sessions/backend/base.rb - About 35 mins to fix

    Avoid too many return statements within this method.
    Open

        return true if @asset_lookup[class_name][record_id][:pushed_at].blank?
    Severity: Major
    Found in lib/sessions/backend/base.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

          return true if @asset_lookup[class_name][record_id][:pushed_at] < @time_now - 7200
      Severity: Major
      Found in lib/sessions/backend/base.rb - About 30 mins to fix

        Method asset_needed_by_updated_at? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def asset_needed_by_updated_at?(class_name, record_id, updated_at)
    return true if @asset_lookup.blank?
    return true if @asset_lookup[class_name].blank?
    return true if @asset_lookup[class_name][record_id].blank?
    return true if @asset_lookup[class_name][record_id][:updated_at] < updated_at
        Severity: Minor
        Found in lib/sessions/backend/base.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status