Sign upLogin

zaption/passport-edmodo

View on GitHub
Star

Showing 8 of 8 total issues

Function userProfile has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

Strategy.prototype.userProfile = function(accessToken, done) {
    var self = this;

    var requestProfile = function(url, redirectCount, cb) {
        self._oauth2.get(url, accessToken, function (err, body, res) {
Severity: Minor
Found in lib/strategy.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function parse has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.parse = function(json) {
    if ('string' == typeof json) {
        json = JSON.parse(json);
    }
Severity: Minor
Found in lib/profile.js - About 1 hr to fix

    Function userProfile has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    Strategy.prototype.userProfile = function(accessToken, done) {
    var self = this;

    var requestProfile = function(url, redirectCount, cb) {
        self._oauth2.get(url, accessToken, function (err, body, res) {
    Severity: Minor
    Found in lib/strategy.js - About 1 hr to fix

      Function parse has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

      exports.parse = function(json) {
    if ('string' == typeof json) {
        json = JSON.parse(json);
    }
      Severity: Minor
      Found in lib/profile.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function authenticate has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      Strategy.prototype.authenticate = function(req, options) {
    if (!options.useTokenFlow) {
        // normal code flow is handled by default OAuth2 strategy
        return OAuth2Strategy.prototype.authenticate.call(this, req, options);
    }
      Severity: Minor
      Found in lib/strategy.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if (json.avatars.large) {
            profile.photos.push({ value: json.avatars.large, type: 'large' });
        }
        Severity: Minor
        Found in lib/profile.js and 1 other location - About 40 mins to fix
        lib/profile.js on lines 37..39

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if (json.avatars.small) {
            profile.photos.push({ value: json.avatars.small, type: 'small' });
        }
        Severity: Minor
        Found in lib/profile.js and 1 other location - About 40 mins to fix
        lib/profile.js on lines 40..42

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function authenticate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        Strategy.prototype.authenticate = function(req, options) {
    if (!options.useTokenFlow) {
        // normal code flow is handled by default OAuth2 strategy
        return OAuth2Strategy.prototype.authenticate.call(this, req, options);
    }
        Severity: Minor
        Found in lib/strategy.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language