Sign upLogin

zaption/passport-edmodo

View on GitHub
Star
lib/strategy.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function userProfile has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

Strategy.prototype.userProfile = function(accessToken, done) {
    var self = this;

    var requestProfile = function(url, redirectCount, cb) {
        self._oauth2.get(url, accessToken, function (err, body, res) {
Severity: Minor
Found in lib/strategy.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function userProfile has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Strategy.prototype.userProfile = function(accessToken, done) {
    var self = this;

    var requestProfile = function(url, redirectCount, cb) {
        self._oauth2.get(url, accessToken, function (err, body, res) {
Severity: Minor
Found in lib/strategy.js - About 1 hr to fix

    Function authenticate has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    Strategy.prototype.authenticate = function(req, options) {
    if (!options.useTokenFlow) {
        // normal code flow is handled by default OAuth2 strategy
        return OAuth2Strategy.prototype.authenticate.call(this, req, options);
    }
    Severity: Minor
    Found in lib/strategy.js - About 1 hr to fix

      Function authenticate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      Strategy.prototype.authenticate = function(req, options) {
    if (!options.useTokenFlow) {
        // normal code flow is handled by default OAuth2 strategy
        return OAuth2Strategy.prototype.authenticate.call(this, req, options);
    }
      Severity: Minor
      Found in lib/strategy.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status