zedseven/Romanization.NET

View on GitHub
Romanization/Languages/Korean/RevisedRomanization.cs

Summary

Maintainability
B
6 hrs
Test Coverage
A
97%

Method Process has a Cognitive Complexity of 41 (exceeds 20 allowed). Consider refactoring.
Open

            [Pure]
            public string Process(string text, bool givenName, bool noun = false, bool hyphenateSyllables = false)
            {
                text = text
                    // Replace common alternate characters
Severity: Minor
Found in Romanization/Languages/Korean/RevisedRomanization.cs - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Process has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

            [Pure]
            public string Process(string text, bool givenName, bool noun = false, bool hyphenateSyllables = false)
            {
                text = text
                    // Replace common alternate characters
Severity: Major
Found in Romanization/Languages/Korean/RevisedRomanization.cs - About 2 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                                        if (!noun && jamoList[i + 1] == 'ㅎ' &&
                                            (jamoList[i] == 'ㄱ' || jamoList[i] == 'ㄷ' || jamoList[i] == 'ㅂ'))
                                            romanizedText.Append(hyphenateSyllables
                                                ? specialCaseRomanization.ToString(false)
                                                : specialCaseRomanization.BaseString.NonAspiratedString);
    Severity: Major
    Found in Romanization/Languages/Korean/RevisedRomanization.cs - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status