zedtux/ruby-git-ce

View on GitHub
lib/git/base.rb

Summary

Maintainability
D
1 day
Test Coverage

Class Base has 63 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Base

    include Git::Base::Factory

    # opens a bare Git Repository - no working directory options
Severity: Major
Found in lib/git/base.rb - About 1 day to fix

    File base.rb has 274 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'git/base/factory'
    
    module Git
    
      class Base
    Severity: Minor
    Found in lib/git/base.rb - About 2 hrs to fix

      Method initialize has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          def initialize(options = {})
            if working_dir = options[:working_directory]
              options[:repository] ||= File.join(working_dir, '.git')
              options[:index] ||= File.join(working_dir, '.git', 'index')
            end
      Severity: Minor
      Found in lib/git/base.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method init has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def self.init(working_dir, opts = {})
            opts[:working_directory] ||= working_dir
            opts[:repository] ||= File.join(opts[:working_directory], '.git')
      
            FileUtils.mkdir_p(opts[:working_directory]) if opts[:working_directory] && !File.directory?(opts[:working_directory])
      Severity: Minor
      Found in lib/git/base.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status