Sign upLogin

zeisler/active_mocker

View on GitHub
Star
lib/active_mocker/attribute_types/enum.rb

Summary

Maintainability
A
35 mins
Test Coverage

Method has too many lines. [16/10] (https://github.com/bbatsov/ruby-style-guide#short-methods)
Open

        def build(db_value_type:, table_name:, attribute:, enums:, ignore_value: false)
          klass               = Class.new(ActiveMocker::AttributeTypes::Enum)
          klass.table_name    = table_name.to_sym
          klass.attribute     = attribute.to_sym
          klass.ignore_value  = ignore_value
Severity: Minor
Found in lib/active_mocker/attribute_types/enum.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [11/10] (https://github.com/bbatsov/ruby-style-guide#short-methods)
Open

      def coerce(key)
        return if key.nil?
        coerced_key = key_type.coerce(key)
        if key && self.class.enums.key?(coerced_key)
          if self.class.ignore_value
Severity: Minor
Found in lib/active_mocker/attribute_types/enum.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for build is too high. [16.67/15] (http://c2.com/cgi/wiki?AbcMetric)
Open

        def build(db_value_type:, table_name:, attribute:, enums:, ignore_value: false)
          klass               = Class.new(ActiveMocker::AttributeTypes::Enum)
          klass.table_name    = table_name.to_sym
          klass.attribute     = attribute.to_sym
          klass.ignore_value  = ignore_value
Severity: Minor
Found in lib/active_mocker/attribute_types/enum.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method coerce has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

      def coerce(key)
        return if key.nil?
        coerced_key = key_type.coerce(key)
        if key && self.class.enums.key?(coerced_key)
          if self.class.ignore_value
Severity: Minor
Found in lib/active_mocker/attribute_types/enum.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Add an empty line after magic comments. (https://github.com/bbatsov/ruby-style-guide#separate-magic-comments-from-code)
Open

require "virtus"
Severity: Minor
Found in lib/active_mocker/attribute_types/enum.rb by rubocop

Checks for a newline after the final magic comment.

Example:

# good
# frozen_string_literal: true

# Some documentation for Person
class Person
  # Some code
end

# bad
# frozen_string_literal: true
# Some documentation for Person
class Person
  # Some code
end

Use a guard clause instead of wrapping the code inside a conditional expression. (https://github.com/bbatsov/ruby-style-guide#no-nested-conditionals)
Open

        if key && self.class.enums.key?(coerced_key)
Severity: Minor
Found in lib/active_mocker/attribute_types/enum.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

Line is too long. [195/120] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
Open

          "ActiveMocker::AttributeTypes::Enum.build(ignore_value: #{ignore_value}, db_value_type: #{db_value_type}, table_name: :#{table_name}, attribute: :#{attribute}, enums: #{enums.inspect})"
Severity: Minor
Found in lib/active_mocker/attribute_types/enum.rb by rubocop

There are no issues that match your filters.

Category
Status