Sign upLogin

zeiv/caseadilla

View on GitHub
Star
app/helpers/caseadilla/caseadilla_helper.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method caseadilla_collection_select has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def caseadilla_collection_select form, obj, attribute, collection, value_method, text_method, options = {}
Severity: Major
Found in app/helpers/caseadilla/caseadilla_helper.rb - About 50 mins to fix

    Method caseadilla_collection_check_boxes has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def caseadilla_collection_check_boxes form, obj, attribute, collection, value_method, text_method, options = {}
    Severity: Major
    Found in app/helpers/caseadilla/caseadilla_helper.rb - About 50 mins to fix

      Method caseadilla_radio_button has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def caseadilla_radio_button form, obj, attribute, tag_value, options = {}
      Severity: Minor
      Found in app/helpers/caseadilla/caseadilla_helper.rb - About 35 mins to fix

        Method caseadilla_file_field has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def caseadilla_file_field form, obj, object_name, attribute, options = {}
        Severity: Minor
        Found in app/helpers/caseadilla/caseadilla_helper.rb - About 35 mins to fix

          Method caseadilla_custom_field has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def caseadilla_custom_field form, obj, attribute, custom_contents, options = {}
          Severity: Minor
          Found in app/helpers/caseadilla/caseadilla_helper.rb - About 35 mins to fix

            Method caseadilla_form_tag_wrapper has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def caseadilla_form_tag_wrapper form_tag, form, obj, attribute, options = {}
            Severity: Minor
            Found in app/helpers/caseadilla/caseadilla_helper.rb - About 35 mins to fix

              Method caseadilla_time_zone_select has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def caseadilla_time_zone_select form, obj, attribute, option_tags, options = {}
              Severity: Minor
              Found in app/helpers/caseadilla/caseadilla_helper.rb - About 35 mins to fix

                Method caseadilla_select has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def caseadilla_select form, obj, attribute, option_tags, options = {}
                Severity: Minor
                Found in app/helpers/caseadilla/caseadilla_helper.rb - About 35 mins to fix

                  Method caseadilla_sort_link has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def caseadilla_sort_link title, column, options = {}
      condition = options[:unless] if options.has_key?(:unless)
      icon_to_show_html = "<div class='table-header-icon'>&nbsp;</div>".html_safe
      if params[:c].to_s == column.to_s
        icon_to_show = params[:d] == 'down' ? 'chevron-up' : 'chevron-down'
                  Severity: Minor
                  Found in app/helpers/caseadilla/caseadilla_helper.rb - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method caseadilla_form_tag_wrapper has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def caseadilla_form_tag_wrapper form_tag, form, obj, attribute, options = {}
        unless options.key? :caseadilla_label
          human_attribute_name = attribute.to_s.humanize
        else
          human_attribute_name = options[:caseadilla_label]
                  Severity: Minor
                  Found in app/helpers/caseadilla/caseadilla_helper.rb - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      def caseadilla_collection_check_boxes form, obj, attribute, collection, value_method, text_method, options = {}
      caseadilla_form_tag_wrapper(collection_check_boxes(obj.class.name.downcase.to_sym, attribute, collection, value_method, text_method, strip_caseadilla_options(options), merged_class_hash(options, 'form-control')), form, obj, attribute, options).html_safe
                  Severity: Minor
                  Found in app/helpers/caseadilla/caseadilla_helper.rb and 1 other location - About 15 mins to fix
                  app/helpers/caseadilla/caseadilla_helper.rb on lines 175..176

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 25.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      def caseadilla_collection_select form, obj, attribute, collection, value_method, text_method, options = {}
      caseadilla_form_tag_wrapper(collection_select(obj.class.name.downcase.to_sym, attribute, collection, value_method, text_method, strip_caseadilla_options(options), merged_class_hash(options, 'form-control')), form, obj, attribute, options).html_safe
                  Severity: Minor
                  Found in app/helpers/caseadilla/caseadilla_helper.rb and 1 other location - About 15 mins to fix
                  app/helpers/caseadilla/caseadilla_helper.rb on lines 179..180

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 25.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status