zendesk/zendesk_api_client_rb

View on GitHub
lib/zendesk_api/resource.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Class Data has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Data
    include Associations

    class << self
      def inherited(klass)
Severity: Minor
Found in lib/zendesk_api/resource.rb - About 2 hrs to fix

    Method initialize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def initialize(client, attributes = {})
          raise "Expected a Hash for attributes, got #{attributes.inspect}" unless attributes.is_a?(Hash)
    
          @association = attributes.delete(:association) || Association.new(:class => self.class)
          @global_params = attributes.delete(:global) || {}
    Severity: Minor
    Found in lib/zendesk_api/resource.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method == has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def ==(other)
          return false unless other
    
          return true if other.object_id == object_id
    
    
    Severity: Minor
    Found in lib/zendesk_api/resource.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status